Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.cc

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/password_manager/chrome_password_manager_client.cc
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.cc b/chrome/browser/password_manager/chrome_password_manager_client.cc
index 4185544f9e8853cb154644e23bf6a0a1acef7580..0579c324fbd26d1415a97e3b91cdcba0150d1129 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.cc
+++ b/chrome/browser/password_manager/chrome_password_manager_client.cc
@@ -259,10 +259,10 @@ bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
ScopedVector<autofill::PasswordForm> local_forms,
ScopedVector<autofill::PasswordForm> federated_forms,
const GURL& origin,
- base::Callback<void(const password_manager::CredentialInfo&)> callback) {
+ const CredentialsCallback& callback) {
// Set up an intercept callback if the prompt is zero-clickable (e.g. just one
// form provided).
- base::Callback<void(const password_manager::CredentialInfo&)> intercept =
+ CredentialsCallback intercept =
local_forms.size() == 1u
? base::Bind(&ChromePasswordManagerClient::OnCredentialsChosen,
base::Unretained(this), callback)
@@ -284,13 +284,11 @@ bool ChromePasswordManagerClient::PromptUserToChooseCredentials(
}
void ChromePasswordManagerClient::OnCredentialsChosen(
- base::Callback<void(const password_manager::CredentialInfo&)> callback,
- const password_manager::CredentialInfo& credential) {
- callback.Run(credential);
- if (credential.type !=
- password_manager::CredentialType::CREDENTIAL_TYPE_EMPTY) {
+ const CredentialsCallback& callback,
+ const autofill::PasswordForm* form) {
+ callback.Run(form);
+ if (form)
PromptUserToEnableAutosigninIfNecessary();
- }
}
void ChromePasswordManagerClient::ForceSavePassword() {
« no previous file with comments | « chrome/browser/password_manager/chrome_password_manager_client.h ('k') | chrome/browser/ui/passwords/manage_passwords_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698