Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4173)

Unified Diff: chrome/browser/ui/passwords/manage_passwords_state.h

Issue 1832933002: Update the |skip_zero_click| flag of a credential when selected in the account chooser. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/passwords/manage_passwords_state.h
diff --git a/chrome/browser/ui/passwords/manage_passwords_state.h b/chrome/browser/ui/passwords/manage_passwords_state.h
index d4b902cfb2122058c4877613b45d160f95d97ae9..f4cf5e4bb37fc5ca5083404ecf504657074e3702 100644
--- a/chrome/browser/ui/passwords/manage_passwords_state.h
+++ b/chrome/browser/ui/passwords/manage_passwords_state.h
@@ -18,7 +18,6 @@
#include "url/gurl.h"
namespace password_manager {
-struct CredentialInfo;
class PasswordFormManager;
class PasswordManagerClient;
}
@@ -29,7 +28,7 @@ class PasswordManagerClient;
class ManagePasswordsState {
public:
using CredentialsCallback =
- base::Callback<void(const password_manager::CredentialInfo&)>;
+ base::Callback<void(const autofill::PasswordForm*)>;
ManagePasswordsState();
~ManagePasswordsState();
@@ -85,12 +84,10 @@ class ManagePasswordsState {
void ProcessLoginsChanged(
const password_manager::PasswordStoreChangeList& changes);
- // Called when the user chooses a credential. Using data from |form| and
- // |credential_type| it constructs the object which next is passed to the
+ // Called when the user chooses a credential. |form| is passed to the
// credentials callback. Method should be called in the
// CREDENTIAL_REQUEST_STATE state.
- void ChooseCredential(const autofill::PasswordForm& form,
- password_manager::CredentialType credential_type);
+ void ChooseCredential(const autofill::PasswordForm* form);
password_manager::ui::State state() const { return state_; }
const GURL& origin() const { return origin_; }

Powered by Google App Engine
This is Rietveld 408576698