ui/native_theme/native_theme_base.cc - Issue 1831883002: Use sk_sp-based shader creation APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/native_theme/native_theme_base.cc

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sprinkle in some std::move and some sk_sp in the API Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/native_theme/native_theme_base.cc

diff --git a/ui/native_theme/native_theme_base.cc b/ui/native_theme/native_theme_base.cc

index 9dbeceeff4176f6e2f6fd0e49eca6b2a11a489e3..017b07afe9675c99b1c2fc2e4b1362d12cd26732 100644

--- a/ui/native_theme/native_theme_base.cc

+++ b/ui/native_theme/native_theme_base.cc

@@ -698,12 +698,11 @@ void NativeThemeBase::PaintButton(SkCanvas* canvas,

std::swap(gradient_bounds[0], gradient_bounds[1]);

SkColor colors[2] = { light_color, base_color };

- skia::RefPtr<SkShader> shader = skia::AdoptRef(

- SkGradientShader::CreateLinear(

- gradient_bounds, colors, NULL, 2, SkShader::kClamp_TileMode));

paint.setStyle(SkPaint::kFill_Style);

paint.setAntiAlias(true);

- paint.setShader(shader.get());

+ paint.setShader(

+ SkGradientShader::MakeLinear(

+ gradient_bounds, colors, NULL, 2, SkShader::kClamp_TileMode));

canvas->drawRoundRect(skrect, SkIntToScalar(1), SkIntToScalar(1), paint);

paint.setShader(NULL);