skia/config/SkUserConfig.h - Issue 1831883002: Use sk_sp-based shader creation APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: skia/config/SkUserConfig.h

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sprinkle in some std::move and some sk_sp in the API Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: skia/config/SkUserConfig.h

diff --git a/skia/config/SkUserConfig.h b/skia/config/SkUserConfig.h

index 3f1d2b7cf7a40751271f6c9372495f5421e9ec15..684c72d2bf80184a94fb78c395ad5f7c13885dc4 100644

--- a/skia/config/SkUserConfig.h

+++ b/skia/config/SkUserConfig.h

@@ -263,10 +263,6 @@ SK_API void SkDebugf_FileLine(const char* file, int line, bool fatal,

# define SK_SUPPORT_LEGACY_PEEKPIXELS_PARMS

#endif

-#ifndef SK_SUPPORT_LEGACY_CREATESHADER_PTR

-# define SK_SUPPORT_LEGACY_CREATESHADER_PTR

f(malita) 2016/03/25 18:31:03 Did we convert Blink already? I guess the bots wi

tomhudson 2016/03/25 19:27:31 Bots were happy with patchset #3; no Blink callers

-#endif

#ifndef SK_SUPPORT_LEGACY_SETSHADER_PTR

# define SK_SUPPORT_LEGACY_SETSHADER_PTR

#endif