Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: ui/gfx/skia_util.cc

Issue 1831883002: Use sk_sp-based shader creation APIs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Sprinkle in some std::move and some sk_sp in the API Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gfx/skia_util.cc
diff --git a/ui/gfx/skia_util.cc b/ui/gfx/skia_util.cc
index 7d554696ad4cdba237a609da569d689ef8f5fc03..ac12cb8fa2c12de285bbc72035c83978195bdeee 100644
--- a/ui/gfx/skia_util.cc
+++ b/ui/gfx/skia_util.cc
@@ -91,14 +91,14 @@ void TransformToFlattenedSkMatrix(const gfx::Transform& transform,
flattened->set(8, SkMScalarToScalar(transform.matrix().get(3, 3)));
}
-skia::RefPtr<SkShader> CreateImageRepShader(const gfx::ImageSkiaRep& image_rep,
+sk_sp<SkShader> CreateImageRepShader(const gfx::ImageSkiaRep& image_rep,
SkShader::TileMode tile_mode,
const SkMatrix& local_matrix) {
return CreateImageRepShaderForScale(image_rep, tile_mode, local_matrix,
image_rep.scale());
}
-skia::RefPtr<SkShader> CreateImageRepShaderForScale(
+sk_sp<SkShader> CreateImageRepShaderForScale(
const gfx::ImageSkiaRep& image_rep,
SkShader::TileMode tile_mode,
const SkMatrix& local_matrix,
@@ -115,12 +115,11 @@ skia::RefPtr<SkShader> CreateImageRepShaderForScale(
shader_scale.setScaleX(local_matrix.getScaleX() / scale);
shader_scale.setScaleY(local_matrix.getScaleY() / scale);
- skia::RefPtr<SkShader> shader = skia::AdoptRef(SkShader::CreateBitmapShader(
- image_rep.sk_bitmap(), tile_mode, tile_mode, &shader_scale));
- return shader;
+ return SkShader::MakeBitmapShader(
+ image_rep.sk_bitmap(), tile_mode, tile_mode, &shader_scale);
}
-skia::RefPtr<SkShader> CreateGradientShader(int start_point,
+sk_sp<SkShader> CreateGradientShader(int start_point,
int end_point,
SkColor start_color,
SkColor end_color) {
@@ -129,8 +128,8 @@ skia::RefPtr<SkShader> CreateGradientShader(int start_point,
grad_points[0].iset(0, start_point);
grad_points[1].iset(0, end_point);
- return skia::AdoptRef(SkGradientShader::CreateLinear(
- grad_points, grad_colors, NULL, 2, SkShader::kClamp_TileMode));
+ return SkGradientShader::MakeLinear(
+ grad_points, grad_colors, NULL, 2, SkShader::kClamp_TileMode);
}
static SkScalar RadiusToSigma(double radius) {

Powered by Google App Engine
This is Rietveld 408576698