Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError.

Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError.

See the spec change: https://github.com/w3c/webcomponents/issues/393

I think the previous behavior should be considered as a bug of the spec.
It would be okay to change the behavior since the compatibility risk is very low.

BUG=531990
Committed: https://crrev.com/14136cef3703e931c8e757ec403e9b204931ff2f
Cr-Commit-Position: refs/heads/master@{#383240}

[hayato, 2016-03-24 09:12:38]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 09:12:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831753002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831753002/1

[hayato, 2016-03-24 09:18:25]

hayato@chromium.org changed reviewers:
+ kochi@chromium.org, tkent@chromium.org

[hayato, 2016-03-24 09:18:26]

PTAL

[kochi, 2016-03-24 09:28:22]

Could you move the layout test which is still relevant to
V1 from //fast/dom/shadow to //shadow-dom?

[hayato, 2016-03-24 10:09:21]

On 2016/03/24 at 09:28:22, kochi wrote:
> Could you move the layout test which is still relevant to
> V1 from //fast/dom/shadow to //shadow-dom?

Yeah, however, can I do it in another CL?
In this CL, I just wanted to *rebase* it to isolate our concerns.

[kochi, 2016-03-24 10:14:25]

On 2016/03/24 10:09:21, hayato wrote:
> On 2016/03/24 at 09:28:22, kochi wrote:
> > Could you move the layout test which is still relevant to
> > V1 from //fast/dom/shadow to //shadow-dom?
> 
> Yeah, however, can I do it in another CL?
> In this CL, I just wanted to *rebase* it to isolate our concerns.

okay, but I think you need to update -expected.txt for the test anyway.

[hayato, 2016-03-24 10:19:28]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-03-24 10:19:31]

rebase expectation

[commit-bot: I haz the power, 2016-03-24 10:19:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831753002/20001

[hayato, 2016-03-24 10:23:10]

On 2016/03/24 at 10:14:25, kochi wrote:
> On 2016/03/24 10:09:21, hayato wrote:
> > On 2016/03/24 at 09:28:22, kochi wrote:
> > > Could you move the layout test which is still relevant to
> > > V1 from //fast/dom/shadow to //shadow-dom?
> > 
> > Yeah, however, can I do it in another CL?
> > In this CL, I just wanted to *rebase* it to isolate our concerns.
> 
> okay, but I think you need to update -expected.txt for the test anyway.

Ops. Done.

[kochi, 2016-03-24 10:37:40]

lgtm

[hayato, 2016-03-24 10:57:38]

The CQ bit was unchecked by hayato@chromium.org

[hayato, 2016-03-24 10:57:41]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2016-03-24 10:57:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831753002/20001

[commit-bot: I haz the power, 2016-03-24 11:27:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 11:27:29]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[hayato, 2016-03-25 02:13:32]

The CQ bit was checked by hayato@chromium.org to run a CQ dry run

[hayato, 2016-03-25 02:13:35]

update expectation

[commit-bot: I haz the power, 2016-03-25 02:13:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831753002/40001

[hayato, 2016-03-25 02:13:52]

The CQ bit was checked by hayato@chromium.org

[hayato, 2016-03-25 02:13:53]

The patchset sent to the CQ was uploaded after l-g-t-m from kochi@chromium.org
Link to the patchset: https://codereview.chromium.org/1831753002/#ps40001
(title: "update expectation")

[commit-bot: I haz the power, 2016-03-25 02:14:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1831753002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1831753002/40001

[commit-bot: I haz the power, 2016-03-25 03:43:28]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-03-25 03:44:27]

Description was changed from

==========
Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError.

See the spec change: https://github.com/w3c/webcomponents/issues/393

I think the previous behavior should be considered as a bug of the spec.
It would be okay to change the behavior since the compatibility risk is very
low.

BUG=531990
==========

to

==========
Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError.

See the spec change: https://github.com/w3c/webcomponents/issues/393

I think the previous behavior should be considered as a bug of the spec.
It would be okay to change the behavior since the compatibility risk is very
low.

BUG=531990

Committed: https://crrev.com/14136cef3703e931c8e757ec403e9b204931ff2f
Cr-Commit-Position: refs/heads/master@{#383240}
==========

[commit-bot: I haz the power, 2016-03-25 03:44:28]

Patchset 3 (id:??) landed as
https://crrev.com/14136cef3703e931c8e757ec403e9b204931ff2f
Cr-Commit-Position: refs/heads/master@{#383240}