Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

Issue 1831753002: Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update expectation Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Neither the name of Google Inc. nor the names of its 10 * * Neither the name of Google Inc. nor the names of its
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 { 106 {
107 ShadowRoot* older = olderShadowRoot(); 107 ShadowRoot* older = olderShadowRoot();
108 while (older && !older->isOpenOrV0()) 108 while (older && !older->isOpenOrV0())
109 older = older->olderShadowRoot(); 109 older = older->olderShadowRoot();
110 ASSERT(!older || older->isOpenOrV0()); 110 ASSERT(!older || older->isOpenOrV0());
111 return older; 111 return older;
112 } 112 }
113 113
114 PassRefPtrWillBeRawPtr<Node> ShadowRoot::cloneNode(bool, ExceptionState& excepti onState) 114 PassRefPtrWillBeRawPtr<Node> ShadowRoot::cloneNode(bool, ExceptionState& excepti onState)
115 { 115 {
116 exceptionState.throwDOMException(DataCloneError, "ShadowRoot nodes are not c lonable."); 116 exceptionState.throwDOMException(NotSupportedError, "ShadowRoot nodes are no t clonable.");
117 return nullptr; 117 return nullptr;
118 } 118 }
119 119
120 String ShadowRoot::innerHTML() const 120 String ShadowRoot::innerHTML() const
121 { 121 {
122 return createMarkup(this, ChildrenOnly); 122 return createMarkup(this, ChildrenOnly);
123 } 123 }
124 124
125 void ShadowRoot::setInnerHTML(const String& markup, ExceptionState& exceptionSta te) 125 void ShadowRoot::setInnerHTML(const String& markup, ExceptionState& exceptionSta te)
126 { 126 {
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
370 DEFINE_TRACE(ShadowRoot) 370 DEFINE_TRACE(ShadowRoot)
371 { 371 {
372 visitor->trace(m_prev); 372 visitor->trace(m_prev);
373 visitor->trace(m_next); 373 visitor->trace(m_next);
374 visitor->trace(m_shadowRootRareData); 374 visitor->trace(m_shadowRootRareData);
375 TreeScope::trace(visitor); 375 TreeScope::trace(visitor);
376 DocumentFragment::trace(visitor); 376 DocumentFragment::trace(visitor);
377 } 377 }
378 378
379 } // namespace blink 379 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698