third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp - Issue 1831753002: Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

Issue 1831753002: Make ShadowRoot.cloneNode() throw NotSupportedError, instead of DataCloneError. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update expectation Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

index f4e47ae4f9a79671bb4fccf419a7739384e9c601..8e3af0d0ac57631243144948e60606fd21c710a4 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

@@ -113,7 +113,7 @@ ShadowRoot* ShadowRoot::olderShadowRootForBindings() const

PassRefPtrWillBeRawPtr<Node> ShadowRoot::cloneNode(bool, ExceptionState& exceptionState)

{

- exceptionState.throwDOMException(DataCloneError, "ShadowRoot nodes are not clonable.");

+ exceptionState.throwDOMException(NotSupportedError, "ShadowRoot nodes are not clonable.");

return nullptr;

}

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/dom/shadow/shadowroot-clonenode-expected.txt ('k') | no next file » | no next file with comments »