Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(905)

Issue 1830453002: WebGL: GL_RGB emulation for IOSurface backed textures. [For reference only] (Closed)

Created:
4 years, 9 months ago by erikchen
Modified:
4 years, 9 months ago
Reviewers:
CC:
chromium-reviews, krit, pdr+graphicswatchlist_chromium.org, drott+blinkwatch_chromium.org, blink-reviews-platform-graphics_chromium.org, f(malita), jam, jbroman, Justin Novosad, danakj+watch_chromium.org, Rik, darin-cc_chromium.org, dshwang, blink-reviews, piman+watch_chromium.org, kinuko+watch, Stephen Chennney, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WebGL: GL_RGB emulation for IOSurface backed textures. [For reference only] This CL allows clients of the command buffer to create GL_RGB internal format IOSurface backed textures. IOSurfaces with GL_RGB internal format are buggy, so the command buffer create a GL_RGBA texture, and emulates a GL_BGR texture. A GL_RGB emulation texture is only guaranteed to function correctly when attached to an FBO. Other operations such as texturing may return incorrect results. BUG=595948 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : Remove debugging. #

Patch Set 3 : Overrides and clang format. #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : style. #

Patch Set 7 : #

Patch Set 8 : #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : Rebase. #

Patch Set 12 : Compile error. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -23 lines) Patch
M content/common/gpu/media/avda_codec_image.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/media/avda_codec_image.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M content/common/gpu/stream_texture_android.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M content/common/gpu/stream_texture_android.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +4 lines, -0 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.h View 3 chunks +7 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/framebuffer_manager.cc View 1 2 3 4 5 9 chunks +80 lines, -5 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 2 3 4 5 6 7 8 9 10 11 3 chunks +23 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_textures.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/image_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer/service/stream_texture_manager_in_process_android.cc View 1 2 3 4 5 6 7 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_definition.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.h View 1 chunk +2 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M gpu/command_buffer/service/texture_manager_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gpu/ipc/common/gpu_memory_buffer_support.cc View 1 2 3 4 5 6 7 8 9 10 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp View 1 2 3 4 5 6 7 8 9 10 2 chunks +9 lines, -9 lines 0 comments Download
M third_party/khronos/GLES2/gl2ext.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M third_party/khronos/README.chromium View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/gfx/mac/io_surface.cc View 1 2 3 4 5 6 7 8 9 10 4 chunks +2 lines, -2 lines 0 comments Download
M ui/gl/gl_image.h View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_egl.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_egl.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_glx.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_glx.cc View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_io_surface.h View 1 2 3 4 5 6 7 8 2 chunks +8 lines, -1 line 0 comments Download
M ui/gl/gl_image_io_surface.mm View 1 2 3 4 5 11 chunks +14 lines, -5 lines 0 comments Download
M ui/gl/gl_image_memory.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_memory.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_stub.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_stub.cc View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/gl/gl_image_surface_texture.h View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -0 lines 0 comments Download
M ui/gl/gl_image_surface_texture.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 38 (22 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/20001
4 years, 9 months ago (2016-03-23 01:45:22 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/176307)
4 years, 9 months ago (2016-03-23 01:56:12 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/40001
4 years, 9 months ago (2016-03-23 18:26:45 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/60001
4 years, 9 months ago (2016-03-23 18:27:56 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_chromium_compile_only_ng/builds/111049) chromeos_x86-generic_chromium_compile_only_ng on ...
4 years, 9 months ago (2016-03-23 18:42:23 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/60001
4 years, 9 months ago (2016-03-23 18:51:54 UTC) #13
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/80001
4 years, 9 months ago (2016-03-23 18:52:34 UTC) #15
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_android/builds/39711)
4 years, 9 months ago (2016-03-23 19:17:40 UTC) #17
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/140001
4 years, 9 months ago (2016-03-23 22:19:40 UTC) #19
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/199761)
4 years, 9 months ago (2016-03-23 22:34:21 UTC) #21
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/160001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/160001
4 years, 9 months ago (2016-03-23 23:15:00 UTC) #23
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/39976)
4 years, 9 months ago (2016-03-23 23:33:12 UTC) #25
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/180001
4 years, 9 months ago (2016-03-24 01:32:51 UTC) #29
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-generic_chromium_compile_only_ng/builds/111378) chromium_presubmit on ...
4 years, 9 months ago (2016-03-24 01:36:04 UTC) #31
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830453002/200001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830453002/200001
4 years, 9 months ago (2016-03-24 01:57:38 UTC) #33
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 02:25:04 UTC) #35
Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

Powered by Google App Engine
This is Rietveld 408576698