gpu/ipc/common/gpu_memory_buffer_support.cc - Issue 1830453002: WebGL: GL_RGB emulation for IOSurface backed textures. [For reference only]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gpu/ipc/common/gpu_memory_buffer_support.cc

Issue 1830453002: WebGL: GL_RGB emulation for IOSurface backed textures. [For reference only] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Compile error. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « gpu/command_buffer/service/texture_manager_unittest.cc ('k') | third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gpu/ipc/common/gpu_memory_buffer_support.cc

diff --git a/gpu/ipc/common/gpu_memory_buffer_support.cc b/gpu/ipc/common/gpu_memory_buffer_support.cc

index 0d1c510f3612a82b49e7894e7a54cc3191e23421..1cb386f94d7bad37a53d07c7cd3be9ad15ac0666 100644

--- a/gpu/ipc/common/gpu_memory_buffer_support.cc

+++ b/gpu/ipc/common/gpu_memory_buffer_support.cc

@@ -33,7 +33,8 @@ bool IsNativeGpuMemoryBufferConfigurationSupported(gfx::BufferFormat format,

case gfx::BufferUsage::GPU_READ:

case gfx::BufferUsage::SCANOUT:

return format == gfx::BufferFormat::BGRA_8888 ||

- format == gfx::BufferFormat::RGBA_8888;

+ format == gfx::BufferFormat::RGBA_8888 ||

+ format == gfx::BufferFormat::BGRX_8888;

case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE:

case gfx::BufferUsage::GPU_READ_CPU_READ_WRITE_PERSISTENT:

return format == gfx::BufferFormat::R_8 ||