Enable DRP config service by default

Enable DRP config service by default

We have been running this experiment at 50% stable, and are
now ready to move to 100%.

This CL does not remove the code that will now be deprecated
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
Committed: https://crrev.com/849951145321fe4f254e87496a855631c6e777e4
Cr-Commit-Position: refs/heads/master@{#383527}

[tbansal1, 2016-03-24 20:50:24]

Patchset #1 (id:1) has been deleted

[tbansal1, 2016-03-24 20:54:23]

Description was changed from

==========
Enable DRP config service by default.

BUG=
==========

to

==========
Enable DRP config service by default.

BUG=597768
==========

[tbansal1, 2016-03-24 20:55:02]

tbansal@chromium.org changed reviewers:
+ sclittle@chromium.org

[tbansal1, 2016-03-24 20:55:02]

sclittle: PTAL. Thanks.

[tbansal1, 2016-03-24 20:57:09]

Description was changed from

==========
Enable DRP config service by default.

BUG=597768
==========

to

==========
Enable DRP config service by default.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

[sclittle, 2016-03-24 22:04:04]

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:187:
return true;
nit: Could you add a comment here explaining why this is just "return true", and
a TODO to delete the code for the old way of configuring the DRP? Just so that
someone without any knowledge of the history of this feature isn't confused.

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
(left):

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h:16:
extern const char kDataReductionProxyConfigURL[];
Should we keep this URL flag to make testing easier?

[tbansal1, 2016-03-24 23:44:38]

Patchset #2 (id:40001) has been deleted

[tbansal1, 2016-03-24 23:44:51]

sclittle: ptal. thanks.

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
(right):

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc:187:
return true;
On 2016/03/24 22:04:03, sclittle wrote:
> nit: Could you add a comment here explaining why this is just "return true",
and
> a TODO to delete the code for the old way of configuring the DRP? Just so that
> someone without any knowledge of the history of this feature isn't confused.

Done.

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
File components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h
(left):

https://codereview.chromium.org/1830343002/diff/20001/components/data_reducti...
components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h:16:
extern const char kDataReductionProxyConfigURL[];
On 2016/03/24 22:04:03, sclittle wrote:
> Should we keep this URL flag to make testing easier?

Done.

[sclittle, 2016-03-25 18:04:59]

LGTM, thanks for doing this!

[tbansal1, 2016-03-25 18:05:50]

The CQ bit was checked by tbansal@chromium.org

[commit-bot: I haz the power, 2016-03-25 18:06:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830343002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830343002/60001

[tbansal1, 2016-03-25 18:16:51]

Description was changed from

==========
Enable DRP config service by default.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

to

==========
Enable DRP config service by default.

We have been running this at 50% stable, and are now ready
to move to 100%.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

[commit-bot: I haz the power, 2016-03-25 18:17:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-25 18:17:25]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tbansal1, 2016-03-25 18:18:08]

Description was changed from

==========
Enable DRP config service by default.

We have been running this at 50% stable, and are now ready
to move to 100%.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

to

==========
Enable DRP config service by default.

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

[tbansal1, 2016-03-25 18:18:42]

tbansal@chromium.org changed reviewers:
+ holte@chromium.org

[tbansal1, 2016-03-25 18:18:43]

holte: PTAL at testing/* and histograms.xml. Thanks.

[Steven Holte, 2016-03-26 01:43:28]

lgtm, but see comment

https://codereview.chromium.org/1830343002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1830343002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72361: -  <int value="-1107762575"
label="enable-data-reduction-proxy-config-client"/>
Not sure it makes sense to remove this since we might want to know what the
value means if we are getting from older clients.

[tbansal1, 2016-03-28 16:38:31]

Description was changed from

==========
Enable DRP config service by default.

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be unused 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

to

==========
Enable DRP config service by default

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be deprecated 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

[tbansal1, 2016-03-28 16:40:01]

https://codereview.chromium.org/1830343002/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/1830343002/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:72361: -  <int value="-1107762575"
label="enable-data-reduction-proxy-config-client"/>
On 2016/03/26 01:43:28, Steven Holte wrote:
> Not sure it makes sense to remove this since we might want to know what the
> value means if we are getting from older clients.

I have reverted that change.

[tbansal1, 2016-03-28 18:33:18]

The CQ bit was checked by tbansal@chromium.org

[tbansal1, 2016-03-28 18:33:18]

The patchset sent to the CQ was uploaded after l-g-t-m from holte@chromium.org,
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/1830343002/#ps80001
(title: "rebased, addressed holte comments")

[commit-bot: I haz the power, 2016-03-28 18:33:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1830343002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1830343002/80001

[commit-bot: I haz the power, 2016-03-28 18:38:36]

Description was changed from

==========
Enable DRP config service by default

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be deprecated 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

to

==========
Enable DRP config service by default

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be deprecated 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

[commit-bot: I haz the power, 2016-03-28 18:38:38]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-03-28 18:42:04]

Description was changed from

==========
Enable DRP config service by default

We have been running this experiment at 50% stable, and are 
now ready to move to 100%.

This CL does not remove the code that will now be deprecated 
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768
==========

to

==========
Enable DRP config service by default

We have been running this experiment at 50% stable, and are
now ready to move to 100%.

This CL does not remove the code that will now be deprecated
because of DRP config being enabled 100% of time. We should
remove that code at some point in future.

BUG=597768

Committed: https://crrev.com/849951145321fe4f254e87496a855631c6e777e4
Cr-Commit-Position: refs/heads/master@{#383527}
==========

[commit-bot: I haz the power, 2016-03-28 18:42:05]

Patchset 3 (id:??) landed as
https://crrev.com/849951145321fe4f254e87496a855631c6e777e4
Cr-Commit-Position: refs/heads/master@{#383527}

[tbansal1, 2016-03-28 21:28:12]

A revert of this CL (patchset #3 id:80001) has been created in
https://codereview.chromium.org/1839783002/ by tbansal@chromium.org.

The reason for reverting is: Reverting because this broke Cronet tests:
https://build.chromium.org/p/chromium.android/builders/Android%20Cronet%20Dat....