Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1830343002: Enable DRP config service by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, addressed holte comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_params.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 1452 matching lines...) Expand 10 before | Expand all | Expand 10 after
1463 {"enable-data-reduction-proxy-lo-fi-preview", 1463 {"enable-data-reduction-proxy-lo-fi-preview",
1464 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME, 1464 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_NAME,
1465 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll, 1465 IDS_FLAGS_ENABLE_DATA_REDUCTION_PROXY_LO_FI_PREVIEW_DESCRIPTION, kOsAll,
1466 SINGLE_VALUE_TYPE( 1466 SINGLE_VALUE_TYPE(
1467 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)}, 1467 data_reduction_proxy::switches::kEnableDataReductionProxyLoFiPreview)},
1468 {"clear-data-reduction-proxy-data-savings", 1468 {"clear-data-reduction-proxy-data-savings",
1469 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME, 1469 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_NAME,
1470 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll, 1470 IDS_FLAGS_DATA_REDUCTION_PROXY_RESET_SAVINGS_DESCRIPTION, kOsAll,
1471 SINGLE_VALUE_TYPE( 1471 SINGLE_VALUE_TYPE(
1472 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)}, 1472 data_reduction_proxy::switches::kClearDataReductionProxyDataSavings)},
1473 {"enable-data-reduction-proxy-config-client",
1474 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_NAME,
1475 IDS_FLAGS_DATA_REDUCTION_PROXY_CONFIG_CLIENT_DESCRIPTION, kOsAll,
1476 SINGLE_VALUE_TYPE(data_reduction_proxy::switches::
1477 kEnableDataReductionProxyConfigClient)},
1478 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST, 1473 {"allow-insecure-localhost", IDS_ALLOW_INSECURE_LOCALHOST,
1479 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll, 1474 IDS_ALLOW_INSECURE_LOCALHOST_DESCRIPTION, kOsAll,
1480 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)}, 1475 SINGLE_VALUE_TYPE(switches::kAllowInsecureLocalhost)},
1481 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME, 1476 {"enable-add-to-shelf", IDS_FLAGS_ADD_TO_SHELF_NAME,
1482 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop, 1477 IDS_FLAGS_ADD_TO_SHELF_DESCRIPTION, kOsDesktop,
1483 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf, 1478 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableAddToShelf,
1484 switches::kDisableAddToShelf)}, 1479 switches::kDisableAddToShelf)},
1485 {"bypass-app-banner-engagement-checks", 1480 {"bypass-app-banner-engagement-checks",
1486 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME, 1481 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_NAME,
1487 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll, 1482 IDS_FLAGS_BYPASS_APP_BANNER_ENGAGEMENT_CHECKS_DESCRIPTION, kOsAll,
(...skipping 413 matching lines...) Expand 10 before | Expand all | Expand 10 after
1901 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) || 1896 if ((!strcmp("data-reduction-proxy-lo-fi", entry.internal_name) ||
1902 !strcmp("enable-data-reduction-proxy-lo-fi-preview", 1897 !strcmp("enable-data-reduction-proxy-lo-fi-preview",
1903 entry.internal_name)) && 1898 entry.internal_name)) &&
1904 channel != version_info::Channel::BETA && 1899 channel != version_info::Channel::BETA &&
1905 channel != version_info::Channel::DEV && 1900 channel != version_info::Channel::DEV &&
1906 channel != version_info::Channel::CANARY && 1901 channel != version_info::Channel::CANARY &&
1907 channel != version_info::Channel::UNKNOWN) { 1902 channel != version_info::Channel::UNKNOWN) {
1908 return true; 1903 return true;
1909 } 1904 }
1910 1905
1911 // enable-data-reduction-proxy-config-client is only available for Chromium
1912 // builds and the Canary/Dev channels.
1913 if (!strcmp("enable-data-reduction-proxy-config-client",
1914 entry.internal_name) &&
1915 channel != version_info::Channel::DEV &&
1916 channel != version_info::Channel::CANARY &&
1917 channel != version_info::Channel::UNKNOWN) {
1918 return true;
1919 }
1920
1921 return false; 1906 return false;
1922 } 1907 }
1923 1908
1924 } // namespace 1909 } // namespace
1925 1910
1926 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage, 1911 void ConvertFlagsToSwitches(flags_ui::FlagsStorage* flags_storage,
1927 base::CommandLine* command_line, 1912 base::CommandLine* command_line,
1928 flags_ui::SentinelsMode sentinels) { 1913 flags_ui::SentinelsMode sentinels) {
1929 if (command_line->HasSwitch(switches::kNoExperiments)) 1914 if (command_line->HasSwitch(switches::kNoExperiments))
1930 return; 1915 return;
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
2032 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2017 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2033 2018
2034 const FeatureEntry* GetFeatureEntries(size_t* count) { 2019 const FeatureEntry* GetFeatureEntries(size_t* count) {
2035 *count = arraysize(kFeatureEntries); 2020 *count = arraysize(kFeatureEntries);
2036 return kFeatureEntries; 2021 return kFeatureEntries;
2037 } 2022 }
2038 2023
2039 } // namespace testing 2024 } // namespace testing
2040 2025
2041 } // namespace about_flags 2026 } // namespace about_flags
OLDNEW
« no previous file with comments | « no previous file | components/data_reduction_proxy/core/common/data_reduction_proxy_params.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698