Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc

Issue 1830343002: Enable DRP config service by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased, addressed holte comments Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
diff --git a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
index 05ee6890c7de2a9bbe32f348351d2ff02391bf13..eaf326aa6c1449e86fb81e16a2dd378dee1f022b 100644
--- a/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
+++ b/components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc
@@ -47,9 +47,6 @@ const char kDevRolloutFieldTrial[] = "DataCompressionProxyDevRollout";
const char kLoFiFieldTrial[] = "DataCompressionProxyLoFi";
const char kLoFiFlagFieldTrial[] = "DataCompressionProxyLoFiFlag";
-const char kConfigServiceFieldTrial[] = "DataReductionProxyConfigService";
-const char kConfigServiceURLParam[] = "url";
-
const char kTrustedSpdyProxyFieldTrialName[] = "DataReductionTrustedSpdyProxy";
// Default URL for retrieving the Data Reduction Proxy configuration.
@@ -186,18 +183,10 @@ bool IsDevRolloutEnabled() {
(FieldTrialList::FindFullName(kDevRolloutFieldTrial) == kEnabled);
}
-std::string GetClientConfigFieldTrialName() {
- return kConfigServiceFieldTrial;
-}
-
bool IsConfigClientEnabled() {
- std::string group_value =
- base::FieldTrialList::FindFullName(kConfigServiceFieldTrial);
- base::StringPiece group = group_value;
- return base::CommandLine::ForCurrentProcess()->HasSwitch(
- data_reduction_proxy::switches::
- kEnableDataReductionProxyConfigClient) ||
- group.starts_with(kEnabled);
+ // TODO(tbansal): crbug.com/597768 Remove the data reduction proxy deprecated
+ // code which was used when config client is not enabled.
+ return true;
}
GURL GetConfigServiceURL() {
@@ -208,11 +197,6 @@ GURL GetConfigServiceURL() {
switches::kDataReductionProxyConfigURL);
}
- if (url.empty()) {
- url = variations::GetVariationParamValue(kConfigServiceFieldTrial,
- kConfigServiceURLParam);
- }
-
if (url.empty())
return GURL(kClientConfigURL);

Powered by Google App Engine
This is Rietveld 408576698