third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp - Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/frame/FrameView.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h » ('j') | third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp b/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

index 75b9adbe4916ac8e7951064252e4108ce431fca7..f4459b973f2548273b57dbc2c2b21a2091d3610b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp

@@ -261,8 +261,8 @@ void LayoutScrollbar::updateScrollbarPart(ScrollbarPart partType, bool destroy)

}

LayoutScrollbarPart* partLayoutObject = m_parts.get(partType);

- if (!partLayoutObject && needLayoutObject) {

- partLayoutObject = LayoutScrollbarPart::createAnonymous(&owningLayoutObject()->document(), this, partType);

+ if (!partLayoutObject && needLayoutObject && m_scrollableArea) {

wkorman 2016/04/05 19:04:19 Also added this check, which fixes otherwise-crash

+ partLayoutObject = LayoutScrollbarPart::createAnonymous(&owningLayoutObject()->document(), m_scrollableArea, this, partType);

m_parts.set(partType, partLayoutObject);

} else if (partLayoutObject && !needLayoutObject) {

m_parts.remove(partType);