third_party/WebKit/Source/core/frame/FrameView.cpp - Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/frame/FrameView.cpp

diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp

index 0f5a9899dd0d0ef9a9960fe7689876bb6839adf3..003da4f23bd64b3ef3c0b3afe04d3ad07a242040 100644

--- a/third_party/WebKit/Source/core/frame/FrameView.cpp

+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp

@@ -2320,7 +2320,7 @@ void FrameView::updateScrollCorner()

if (cornerStyle) {

if (!m_scrollCorner)

- m_scrollCorner = LayoutScrollbarPart::createAnonymous(doc);

+ m_scrollCorner = LayoutScrollbarPart::createAnonymous(doc, this);

m_scrollCorner->setStyleWithWritingModeOfParent(cornerStyle.release());

setScrollCornerNeedsPaintInvalidation();

} else if (m_scrollCorner) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutScrollbar.cpp » ('J')