Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(606)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h

Issue 1830333002: Correct visual rects for scroll corner/resizer and non-frame composited scroll bars. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Don't create a LayoutScrollbartPart if we've no scrollable area. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h b/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
index b1f29f248e5dcdfca77799acf20ed9bfeb82bdc2..0a17d17cef107453ef38905718533d36ec937d90 100644
--- a/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
+++ b/third_party/WebKit/Source/core/layout/LayoutScrollbarPart.h
@@ -35,7 +35,8 @@ class LayoutScrollbar;
class LayoutScrollbarPart final : public LayoutBlock {
public:
- static LayoutScrollbarPart* createAnonymous(Document*, LayoutScrollbar* = nullptr, ScrollbarPart = NoPart);
+ static LayoutScrollbarPart* createAnonymous(Document*, ScrollableArea*,
+ LayoutScrollbar* = nullptr, ScrollbarPart = NoPart);
~LayoutScrollbarPart() override;
const char* name() const override { return "LayoutScrollbarPart"; }
@@ -85,7 +86,7 @@ protected:
void imageChanged(WrappedImagePtr, const IntRect* = nullptr) override;
private:
- LayoutScrollbarPart(LayoutScrollbar*, ScrollbarPart);
+ LayoutScrollbarPart(ScrollableArea*, LayoutScrollbar*, ScrollbarPart);
void computePreferredLogicalWidths() override;
@@ -112,6 +113,7 @@ private:
bool allowsOverflowClip() const override { return false; }
+ UntracedMember<ScrollableArea> m_scrollableArea;
UntracedMember<LayoutScrollbar> m_scrollbar;
ScrollbarPart m_part;
};

Powered by Google App Engine
This is Rietveld 408576698