Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1830113003: Rename bindings test IDL members to use "origin trial" terminology (Closed)

Created:
4 years, 9 months ago by chasej
Modified:
4 years, 8 months ago
Reviewers:
haraken, iclelland
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@586594-fix-whitespace
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename bindings test IDL members to use "origin trial" terminology This is the second CL in a series to cleanup the bindings tests/results for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs to simplify the final CL to make the [OriginTrialEnabled] and [RuntimeEnabled] attributes mutually exclusive. This CL renames any members in the test IDLs that still use the old "experiment" naming. Some code was missed in previous CLs to rename the attribute to [OriginTrialEnabled] from [APIExperimentEnabled]. CLs in the series: 1) https://codereview.chromium.org/1828973003/, Fix indentation in template 2) This CL, rename test IDL members 3) https://codereview.chromium.org/1838813002/, Separate bindings tests for [OriginTrialEnabled] BUG=586594 Committed: https://crrev.com/cc6d0125ccb0f1d775f7ffd0be1f61d67aea9716 Cr-Commit-Position: refs/heads/master@{#385177}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Cleaner renames of constants in test IDL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -325 lines) Patch
M third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl View 1 2 5 chunks +15 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 2 19 chunks +310 lines, -310 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
chasej
haraken, iclelland, please take a look.
4 years, 8 months ago (2016-04-04 21:00:37 UTC) #5
haraken
LGTM
4 years, 8 months ago (2016-04-04 23:57:56 UTC) #6
iclelland
lgtm
4 years, 8 months ago (2016-04-05 12:59:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1830113003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1830113003/40001
4 years, 8 months ago (2016-04-05 14:45:09 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-05 15:44:21 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 15:45:34 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/cc6d0125ccb0f1d775f7ffd0be1f61d67aea9716
Cr-Commit-Position: refs/heads/master@{#385177}

Powered by Google App Engine
This is Rietveld 408576698