Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 1828973003: Fix indentation in template for [OriginTrialEnabled] (Closed)

Created:
4 years, 9 months ago by chasej
Modified:
4 years, 8 months ago
Reviewers:
haraken, iclelland
CC:
chromium-reviews, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix indentation in template for [OriginTrialEnabled] This is the first CL in a series to cleanup the bindings tests/results for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs to simplify the final CL to make the [OriginTrialEnabled] and [RuntimeEnabled] attributes mutually exclusive. This CL just corrects the indentation in generated code for the [OriginTrialEnabled] attribute. The template had extra indentation which caused a mismatch with surrounding code. CLs in the series: 1) This CL, Fix indentation in template 2) https://codereview.chromium.org/1830113003/, Rename test IDL members 3) https://codereview.chromium.org/1838813002/, Separate bindings tests for [OriginTrialEnabled] BUG=586594 Committed: https://crrev.com/669cb1aa76222f4ea77a88d842c4d52814735b19 Cr-Commit-Position: refs/heads/master@{#385160}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -615 lines) Patch
M third_party/WebKit/Source/bindings/templates/utilities.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 1 108 chunks +540 lines, -540 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 1 12 chunks +60 lines, -60 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 2 chunks +10 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (5 generated)
chasej
haraken, iclelland, please take a look. haraken, you reviewed the CL that added the [OriginTrialEnabled] ...
4 years, 8 months ago (2016-04-04 20:58:07 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-04 23:57:28 UTC) #4
iclelland
lgtm
4 years, 8 months ago (2016-04-05 12:58:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828973003/20001
4 years, 8 months ago (2016-04-05 13:14:59 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-05 13:23:07 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-05 13:24:23 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/669cb1aa76222f4ea77a88d842c4d52814735b19
Cr-Commit-Position: refs/heads/master@{#385160}

Powered by Google App Engine
This is Rietveld 408576698