Separate bindings tests for [OriginTrialEnabled]

Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
Committed: https://crrev.com/91b0af63d1526c7368db17a80c1137021146ea0d
Cr-Commit-Position: refs/heads/master@{#385196}

[chasej, 2016-04-04 17:33:48]

Description was changed from

==========
Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

to

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to set the stage for the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

[chasej, 2016-04-04 17:39:26]

Description was changed from

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to set the stage for the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

to

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

[chasej, 2016-04-04 21:01:22]

chasej@chromium.org changed reviewers:
+ haraken@chromium.org, iclelland@chromium.org

[chasej, 2016-04-04 21:01:22]

haraken, iclelland, please take a look.

[haraken, 2016-04-04 23:59:39]

LGTM

[iclelland, 2016-04-05 13:14:50]

This CL leaves us without any tests at all on attributes with
[OriginTrialEnabled] -- the actual call to OriginTrials::<feature>Enabled
doesn't seem to appear in any tests after this. Is that intentional?

[chasej, 2016-04-05 15:32:19]

On 2016/04/05 13:14:50, iclelland wrote:
> This CL leaves us without any tests at all on attributes with
> [OriginTrialEnabled] -- the actual call to OriginTrials::<feature>Enabled
> doesn't seem to appear in any tests after this. Is that intentional?

No, there are still tests on attributes with [OriginTrialEnabled], just not in
the files changed in this CL. In .../tests/idls/core/TestObject.idl, the
attribute is applied to originTrialEnabledLongAttribute. For that attribute,
there are corresponding calls to OriginTrials::<feature>Enabled in
.../results/core/V8TestObject.cpp. Those are existing tests, which are unchanged
in this CL.

[iclelland, 2016-04-05 15:33:43]

Okay, that makes sense; I see those now. This LGTM.

[chasej, 2016-04-05 15:59:49]

The CQ bit was checked by chasej@chromium.org

[commit-bot: I haz the power, 2016-04-05 16:00:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1838813002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1838813002/40001

[commit-bot: I haz the power, 2016-04-05 16:58:15]

Description was changed from

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

to

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

[commit-bot: I haz the power, 2016-04-05 16:58:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-05 16:59:27]

Description was changed from

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594
==========

to

==========
Separate bindings tests for [OriginTrialEnabled]

This is the third CL in a series to cleanup the bindings tests/results
for the [OriginTrialEnabled] attribute. The cleanups are in separate CLs
to simplify the final CL to make the [OriginTrialEnabled] and
[RuntimeEnabled] attributes mutually exclusive.

This CL adds a separate IDL interface to test the [OriginTrialEnabled]
attribute. Previously, both [RuntimeEnabled] and [OriginTrialEnabled]
were applied to the same test IDL. This effectively hid/nullified a
number of tests for [RuntimeEnabled].

CLs in the series:
1) https://codereview.chromium.org/1828973003/, Fix indentation in template
2) https://codereview.chromium.org/1830113003/, Rename test IDL members
3) This CL, Separate bindings tests for [OriginTrialEnabled]

BUG=586594

Committed: https://crrev.com/91b0af63d1526c7368db17a80c1137021146ea0d
Cr-Commit-Position: refs/heads/master@{#385196}
==========

[commit-bot: I haz the power, 2016-04-05 16:59:27]

Patchset 3 (id:??) landed as
https://crrev.com/91b0af63d1526c7368db17a80c1137021146ea0d
Cr-Commit-Position: refs/heads/master@{#385196}