[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
Committed: https://crrev.com/682417e0c5057a4823bc9eeaea5dc2417edbf10b
Cr-Commit-Position: refs/heads/master@{#393835}

[hiroshige, 2016-03-23 17:37:24]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

BUG=
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

BUG=
==========

[hiroshige, 2016-03-23 18:34:14]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-23 18:34:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/20001

[commit-bot: I haz the power, 2016-03-23 19:02:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-23 19:02:09]

Dry run: Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[hiroshige, 2016-04-14 11:43:52]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

BUG=
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

BUG=603462
==========

[hiroshige, 2016-04-14 11:44:22]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-14 11:44:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/60001

[commit-bot: I haz the power, 2016-04-14 13:02:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-14 13:02:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2016-04-18 06:57:20]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 06:57:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/80001

[commit-bot: I haz the power, 2016-04-18 08:22:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 08:22:06]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-11 09:43:09]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

BUG=603462
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache in
InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

[hiroshige, 2016-05-11 09:43:16]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-11 09:43:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/120001

[hiroshige, 2016-05-11 09:44:12]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache in
InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache in
InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...

BUG=603462
==========

[hiroshige, 2016-05-11 09:46:00]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache in
InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...

BUG=603462
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...

BUG=603462
==========

[commit-bot: I haz the power, 2016-05-11 11:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-11 11:39:13]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-12 08:47:38]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...

BUG=603462
==========

to

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

[hiroshige, 2016-05-12 08:50:41]

Description was changed from

==========
Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

to

==========
[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

[hiroshige, 2016-05-12 08:50:41]

hiroshige@chromium.org changed reviewers:
+ dgozman@chromium.org, japhet@chromium.org

[hiroshige, 2016-05-12 08:50:59]

PTAL.

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp (left):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:554: if
(resourceLoader && !isNotModified)
I'm not so sure whether we can remove the |!isNotModified| check here, but at
least this CL passes the tests that were added together with the
|!isNotModified| check [1].
[1]
https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...

[Nate Chapin, 2016-05-12 19:36:54]

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp (left):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:554: if
(resourceLoader && !isNotModified)
On 2016/05/12 08:50:59, hiroshige wrote:
> I'm not so sure whether we can remove the |!isNotModified| check here, but at
> least this CL passes the tests that were added together with the
> |!isNotModified| check [1].
> [1]
>
https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...
> 

That's probably legacy. We now revalidate with the same Resource as the original
request, rather than creating a proxy Resource. I think this was to ensure that
we used the real revalidated Resource instead of the proxy Resource.

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:146: Resource*
mainResource() const { return m_mainResource.get(); }
Instead of exposing this, can we pass the Resource* through the
InspectorInstrumentation calls?

[dgozman, 2016-05-12 19:58:09]

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
(right):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:178:
didReceiveResourceResponse(frame, identifier, loader, r,
loader->mainResource());
Let's pass Resource* explicitly to |canceledAfterReceivedResourceResponse| and
|continueWithPolicyIgnore|.

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp (left):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:554: if
(resourceLoader && !isNotModified)
On 2016/05/12 08:50:59, hiroshige wrote:
> I'm not so sure whether we can remove the |!isNotModified| check here, but at
> least this CL passes the tests that were added together with the
> |!isNotModified| check [1].
> [1]
>
https://chromium.googlesource.com/chromium/src/+/d70c5978acbe10aae744abd437bc...
> 

Looks fine.

[Nate Chapin, 2016-05-12 21:18:19]

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp (left):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:555:
cachedResource = resourceLoader->cachedResource();
By the way, this is one of only two uses of ResourceLoader::cachedResource(),
and the other use (ResourceFetcher::willStartLoadingResource) looks to be
trivial to remove. Can we delete that in this patch, too?

[hiroshige, 2016-05-13 05:56:00]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-13 05:56:15]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/140001

[commit-bot: I haz the power, 2016-05-13 07:39:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-13 07:39:40]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2016-05-13 08:40:11]

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp
(right):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp:178:
didReceiveResourceResponse(frame, identifier, loader, r,
loader->mainResource());
On 2016/05/12 19:58:09, dgozman wrote:
> Let's pass Resource* explicitly to |canceledAfterReceivedResourceResponse| and
> |continueWithPolicyIgnore|.

Done.

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp (left):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:555:
cachedResource = resourceLoader->cachedResource();
On 2016/05/12 21:18:19, Nate Chapin wrote:
> By the way, this is one of only two uses of ResourceLoader::cachedResource(),
> and the other use (ResourceFetcher::willStartLoadingResource) looks to be
> trivial to remove. Can we delete that in this patch, too?

Created a separate CL:
https://codereview.chromium.org/1977743002/.

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/loader/DocumentLoader.h (right):

https://codereview.chromium.org/1829803002/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/loader/DocumentLoader.h:146: Resource*
mainResource() const { return m_mainResource.get(); }
On 2016/05/12 19:36:53, Nate Chapin wrote:
> Instead of exposing this, can we pass the Resource* through the
> InspectorInstrumentation calls?

Done.

[Nate Chapin, 2016-05-13 16:59:32]

lgtm

[dgozman, 2016-05-13 17:24:47]

lgtm

[hiroshige, 2016-05-16 13:54:05]

The CQ bit was checked by hiroshige@chromium.org

[commit-bot: I haz the power, 2016-05-16 13:54:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1829803002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1829803002/140001

[commit-bot: I haz the power, 2016-05-16 15:28:49]

Description was changed from

==========
[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

to

==========
[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

[commit-bot: I haz the power, 2016-05-16 15:28:51]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-05-16 15:30:21]

Description was changed from

==========
[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462
==========

to

==========
[WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Instead of retrieving Resource via ResourceLoader and MemoryCache
(via InspectorPageAgent::cachedResource())
in InspectorResourceAgent::didReceiveResourceResponse(),
this CL passes a Resource pointer directly from loader to Inspector,
in order to reduce dependencies from Inspector to MemoryCache.

BUG=603462

Committed: https://crrev.com/682417e0c5057a4823bc9eeaea5dc2417edbf10b
Cr-Commit-Position: refs/heads/master@{#393835}
==========

[commit-bot: I haz the power, 2016-05-16 15:30:23]

Patchset 8 (id:??) landed as
https://crrev.com/682417e0c5057a4823bc9eeaea5dc2417edbf10b
Cr-Commit-Position: refs/heads/master@{#393835}