third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl - Issue 1829803002: [WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

Issue 1829803002: [WeakMemoryCache] Do not lookup MemoryCache when adding resource to Inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@MemoryCache_MakeWeak2d

Patch Set: Do not expose DocumentLoader::mainResource() Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorInstrumentation.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorInstrumentationCustomInl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

diff --git a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

index 4044b235dfdc03d6c272f316f3aca98f3f7cbf41..db186350d08ff4bd30d2bd7622e4ca6b1116c479 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

+++ b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

@@ -155,7 +155,7 @@ class XMLHttpRequest;

void markResourceAsCached(LocalFrame*, unsigned long identifier);

[Resource]

- void didReceiveResourceResponse([Keep] LocalFrame*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, ResourceLoader*);

+ void didReceiveResourceResponse([Keep] LocalFrame*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, Resource*);

[Resource]

void didReceiveData([Keep] LocalFrame*, unsigned long identifier, const char* data, int dataLength, int encodedDataLength);

@@ -164,7 +164,7 @@ class XMLHttpRequest;

void didFinishLoading(LocalFrame* frame, unsigned long identifier, double finishTime, int64_t encodedDataLength);

[Resource]

- void didReceiveCORSRedirectResponse([Keep] LocalFrame*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, ResourceLoader*);

+ void didReceiveCORSRedirectResponse([Keep] LocalFrame*, unsigned long identifier, DocumentLoader*, const ResourceResponse&, Resource*);

[Resource]

void didFailLoading(LocalFrame* frame, unsigned long identifier, const ResourceError&);