Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1977743002: Remove ResourceLoader::cachedResource() (Closed)

Created:
4 years, 7 months ago by hiroshige
Modified:
4 years, 7 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, tyoshino+watch_chromium.org, Yoav Weiss, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, Nate Chapin
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp1829803002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ResourceLoader::cachedResource() BUG=None Committed: https://crrev.com/adb404b4d1eaa1992f4cd7369eef73ce97efb682 Cr-Commit-Position: refs/heads/master@{#393865}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/fetch/ResourceFetcher.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/fetch/ResourceLoader.h View 1 chunk +0 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1829803002 Patch 140001

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977743002/1
4 years, 7 months ago (2016-05-13 05:59:41 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-13 07:23:48 UTC) #4
hiroshige
PTAL.
4 years, 7 months ago (2016-05-13 08:39:30 UTC) #6
Nate Chapin
lgtm
4 years, 7 months ago (2016-05-13 16:58:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1977743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1977743002/1
4 years, 7 months ago (2016-05-16 16:27:20 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-16 18:11:24 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-16 18:13:05 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/adb404b4d1eaa1992f4cd7369eef73ce97efb682
Cr-Commit-Position: refs/heads/master@{#393865}

Powered by Google App Engine
This is Rietveld 408576698