Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1829713002: Move SVGTextMetrics::constructTextRun to SVGTextMetricsBuilder (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SVGTextMetrics::constructTextRun to SVGTextMetricsBuilder New resting place is the SVGTextMetricsCalculator helper class. This avoids using this function to create runs based on the wrong BiDi context. Also wrap the static bits of SVGTextMetricsBuilder.cpp in an unnamed namespace, removing a few 'static' keywords. BUG=596721, 594058 Committed: https://crrev.com/9aa3054b0d2bacf5cc9774de798ebb35cfa88f01 Cr-Commit-Position: refs/heads/master@{#382938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -37 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp View 2 chunks +0 lines, -29 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 7 chunks +38 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
fs
4 years, 9 months ago (2016-03-23 15:55:18 UTC) #2
pdr.
LGTM
4 years, 9 months ago (2016-03-23 21:42:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1829713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1829713002/1
4 years, 9 months ago (2016-03-23 21:43:04 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 22:12:35 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:15:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9aa3054b0d2bacf5cc9774de798ebb35cfa88f01
Cr-Commit-Position: refs/heads/master@{#382938}

Powered by Google App Engine
This is Rietveld 408576698