Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1825613005: More explicit SVGTextMetrics construction (Closed)

Created:
4 years, 9 months ago by fs
Modified:
4 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, f(malita), fs, gyuyoung2, jchaffraix+rendering, kouhei+svg_chromium.org, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@svg-metrics-cleanup-2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

More explicit SVGTextMetrics construction This makes SVGTextMetrics dumber - essentially POD - leaving all measuring etc. to whoever creates one (SVGTextMetricsBuilder/Calculator) for a minor "cost" in complexity. This makes SVGTextMetrics not depend on LineLayoutSVGInlineText. Drop SVGTextMetrics::setWidth too since it's unused. BUG=594058 Committed: https://crrev.com/08441660b5ba7c44f233e34379ef1dda562d046a Cr-Commit-Position: refs/heads/master@{#382944}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -20 lines) Patch
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h View 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp View 2 chunks +6 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/SVGTextMetricsBuilder.cpp View 3 chunks +5 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (5 generated)
fs
4 years, 9 months ago (2016-03-23 16:35:52 UTC) #2
pdr.
LGTM
4 years, 9 months ago (2016-03-23 21:37:57 UTC) #3
commit-bot: I haz the power
This CL has an open dependency (Issue 1829713002 Patch 1). Please resolve the dependency and ...
4 years, 9 months ago (2016-03-23 21:38:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1825613005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1825613005/1
4 years, 9 months ago (2016-03-23 22:16:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 22:22:17 UTC) #9
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 22:24:30 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/08441660b5ba7c44f233e34379ef1dda562d046a
Cr-Commit-Position: refs/heads/master@{#382944}

Powered by Google App Engine
This is Rietveld 408576698