Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Side by Side Diff: third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.h

Issue 1829713002: Move SVGTextMetrics::constructTextRun to SVGTextMetricsBuilder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved. 2 * Copyright (C) Research In Motion Limited 2010-2012. All rights reserved.
3 * 3 *
4 * This library is free software; you can redistribute it and/or 4 * This library is free software; you can redistribute it and/or
5 * modify it under the terms of the GNU Library General Public 5 * modify it under the terms of the GNU Library General Public
6 * License as published by the Free Software Foundation; either 6 * License as published by the Free Software Foundation; either
7 * version 2 of the License, or (at your option) any later version. 7 * version 2 of the License, or (at your option) any later version.
8 * 8 *
9 * This library is distributed in the hope that it will be useful, 9 * This library is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
12 * Library General Public License for more details. 12 * Library General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU Library General Public License 14 * You should have received a copy of the GNU Library General Public License
15 * along with this library; see the file COPYING.LIB. If not, write to 15 * along with this library; see the file COPYING.LIB. If not, write to
16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor, 16 * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
17 * Boston, MA 02110-1301, USA. 17 * Boston, MA 02110-1301, USA.
18 */ 18 */
19 19
20 #ifndef SVGTextMetrics_h 20 #ifndef SVGTextMetrics_h
21 #define SVGTextMetrics_h 21 #define SVGTextMetrics_h
22 22
23 #include "platform/text/TextDirection.h"
24 #include "wtf/Allocator.h" 23 #include "wtf/Allocator.h"
25 24
26 namespace blink { 25 namespace blink {
27 26
28 enum class FontOrientation; 27 enum class FontOrientation;
29 class LineLayoutSVGInlineText; 28 class LineLayoutSVGInlineText;
30 class TextRun;
31 29
32 class SVGTextMetrics { 30 class SVGTextMetrics {
33 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW(); 31 DISALLOW_NEW_EXCEPT_PLACEMENT_NEW();
34 public: 32 public:
35 enum MetricsType { 33 enum MetricsType {
36 SkippedSpaceMetrics 34 SkippedSpaceMetrics
37 }; 35 };
38 36
39 SVGTextMetrics(); 37 SVGTextMetrics();
40 SVGTextMetrics(MetricsType); 38 SVGTextMetrics(MetricsType);
41 SVGTextMetrics(LineLayoutSVGInlineText, unsigned length, float width); 39 SVGTextMetrics(LineLayoutSVGInlineText, unsigned length, float width);
42 40
43 static TextRun constructTextRun(LineLayoutSVGInlineText, unsigned position, unsigned length, TextDirection);
44
45 bool isEmpty() const { return !m_width && !m_height && m_length <= 1; } 41 bool isEmpty() const { return !m_width && !m_height && m_length <= 1; }
46 42
47 float width() const { return m_width; } 43 float width() const { return m_width; }
48 void setWidth(float width) { m_width = width; } 44 void setWidth(float width) { m_width = width; }
49 45
50 float height() const { return m_height; } 46 float height() const { return m_height; }
51 47
52 // TODO(kojii): We should store logical width (advance) and height instead 48 // TODO(kojii): We should store logical width (advance) and height instead
53 // of storing physical and calculate logical. crbug.com/544767 49 // of storing physical and calculate logical. crbug.com/544767
54 float advance(FontOrientation) const; 50 float advance(FontOrientation) const;
55 unsigned length() const { return m_length; } 51 unsigned length() const { return m_length; }
56 52
57 private: 53 private:
58 float m_width; 54 float m_width;
59 float m_height; 55 float m_height;
60 unsigned m_length; 56 unsigned m_length;
61 }; 57 };
62 58
63 } // namespace blink 59 } // namespace blink
64 60
65 #endif 61 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/svg/SVGTextMetrics.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698