Chrome not considering Underline Position from Font

Currently Underline Position is not calculated from Font Metrics, by
default Blink makes 1-pixel gap between baseline and underline
position. This patch adds support for to obtain Underline position
from Font Metrics

Skia patch is in review process for Underline Thickness and Position, added comments to Skia related Blink files which needs to update once Skia patch is committed.

BUG=347510
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171050

[h.joshi, 2014-02-28 05:01:44]

Pls review

[eae, 2014-02-28 17:37:58]

Overall this is a great change, I do have a couple of comments though.

https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
File Source/core/rendering/InlineTextBox.cpp (right):

https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
Source/core/rendering/InlineTextBox.cpp:920: gap =
-fontMetrics.underlinePosition();
Computing the gap and then immediately overwriting the value seems wasteful.

How about

if (fontMetrics.underlinePosition())
  gap = -fontMetrics.underlinePosition();
else
  gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));

or

const int gap = fontMetrics.underlinePosition()
    ? -fontMetrics.underlinePosition();
    : std::max<int>(1, ceilf(textDecorationThickness / 2.f));

preserving the comments, obviously.

https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):

https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default calculation is
done.
Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014-03-01 03:21:04]

Okey, will make suggested changes and upload new patch for review.


On 2014/02/28 17:37:58, eae wrote:
> Overall this is a great change, I do have a couple of comments though.
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> File Source/core/rendering/InlineTextBox.cpp (right):
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> Source/core/rendering/InlineTextBox.cpp:920: gap =
> -fontMetrics.underlinePosition();
> Computing the gap and then immediately overwriting the value seems wasteful.
> 
> How about
> 
> if (fontMetrics.underlinePosition())
>   gap = -fontMetrics.underlinePosition();
> else
>   gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> 
> or
> 
> const int gap = fontMetrics.underlinePosition()
>     ? -fontMetrics.underlinePosition();
>     : std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> 
> preserving the comments, obviously.
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default calculation
is
> done.
> Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014-03-01 03:36:12]

https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
File Source/core/rendering/InlineTextBox.cpp (right):

https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
Source/core/rendering/InlineTextBox.cpp:920: gap =
-fontMetrics.underlinePosition();
Will make changes in next patch.

On 2014/02/28 17:37:59, eae wrote:
> Computing the gap and then immediately overwriting the value seems wasteful.
> 
> How about
> 
> if (fontMetrics.underlinePosition())
>   gap = -fontMetrics.underlinePosition();
> else
>   gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> 
> or
> 
> const int gap = fontMetrics.underlinePosition()
>     ? -fontMetrics.underlinePosition();
>     : std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> 
> preserving the comments, obviously.

https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):

https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default calculation is
done.
Will add FIXME comment in next patch.

On 2014/02/28 17:37:59, eae wrote:
> Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014-03-01 03:46:28]

Added new patch with comment fix.

On 2014/03/01 03:36:12, h.joshi wrote:
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> File Source/core/rendering/InlineTextBox.cpp (right):
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> Source/core/rendering/InlineTextBox.cpp:920: gap =
> -fontMetrics.underlinePosition();
> Will make changes in next patch.
> 
> On 2014/02/28 17:37:59, eae wrote:
> > Computing the gap and then immediately overwriting the value seems wasteful.
> > 
> > How about
> > 
> > if (fontMetrics.underlinePosition())
> >   gap = -fontMetrics.underlinePosition();
> > else
> >   gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > 
> > or
> > 
> > const int gap = fontMetrics.underlinePosition()
> >     ? -fontMetrics.underlinePosition();
> >     : std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > 
> > preserving the comments, obviously.
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> 
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default calculation
is
> done.
> Will add FIXME comment in next patch.
> 
> On 2014/02/28 17:37:59, eae wrote:
> > Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014-03-02 06:18:23]

Skia changes (https://codereview.chromium.org/152073003/) are committed, need to
follow when these Skia changes are taken in Blink.

On 2014/03/01 03:46:28, h.joshi wrote:
> Added new patch with comment fix.
> 
> On 2014/03/01 03:36:12, h.joshi wrote:
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> > File Source/core/rendering/InlineTextBox.cpp (right):
> > 
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> > Source/core/rendering/InlineTextBox.cpp:920: gap =
> > -fontMetrics.underlinePosition();
> > Will make changes in next patch.
> > 
> > On 2014/02/28 17:37:59, eae wrote:
> > > Computing the gap and then immediately overwriting the value seems
wasteful.
> > > 
> > > How about
> > > 
> > > if (fontMetrics.underlinePosition())
> > >   gap = -fontMetrics.underlinePosition();
> > > else
> > >   gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > > 
> > > or
> > > 
> > > const int gap = fontMetrics.underlinePosition()
> > >     ? -fontMetrics.underlinePosition();
> > >     : std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > > 
> > > preserving the comments, obviously.
> > 
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> > File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> > 
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> > Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default
calculation
> is
> > done.
> > Will add FIXME comment in next patch.
> > 
> > On 2014/02/28 17:37:59, eae wrote:
> > > Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014-03-05 01:18:48]

Pls review.

On 2014/03/02 06:18:23, h.joshi wrote:
> Skia changes (https://codereview.chromium.org/152073003/) are committed, need
to
> follow when these Skia changes are taken in Blink.
> 
> On 2014/03/01 03:46:28, h.joshi wrote:
> > Added new patch with comment fix.
> > 
> > On 2014/03/01 03:36:12, h.joshi wrote:
> > >
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> > > File Source/core/rendering/InlineTextBox.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/core/rendering/In...
> > > Source/core/rendering/InlineTextBox.cpp:920: gap =
> > > -fontMetrics.underlinePosition();
> > > Will make changes in next patch.
> > > 
> > > On 2014/02/28 17:37:59, eae wrote:
> > > > Computing the gap and then immediately overwriting the value seems
> wasteful.
> > > > 
> > > > How about
> > > > 
> > > > if (fontMetrics.underlinePosition())
> > > >   gap = -fontMetrics.underlinePosition();
> > > > else
> > > >   gap = std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > > > 
> > > > or
> > > > 
> > > > const int gap = fontMetrics.underlinePosition()
> > > >     ? -fontMetrics.underlinePosition();
> > > >     : std::max<int>(1, ceilf(textDecorationThickness / 2.f));
> > > > 
> > > > preserving the comments, obviously.
> > > 
> > >
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> > > File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/182923003/diff/20001/Source/platform/fonts/sk...
> > > Source/platform/fonts/skia/SimpleFontDataSkia.cpp:138: // default
> calculation
> > is
> > > done.
> > > Will add FIXME comment in next patch.
> > > 
> > > On 2014/02/28 17:37:59, eae wrote:
> > > > Could you add a FIXME comment with a link to the bug in question?

[jungshik at Google, 2014-03-06 01:05:32]

LGTM if you want to land this CL as it is. My preference is to wait until skia
change is rolled in and do the right thing on Linux/Windows.

https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):

https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
Source/platform/fonts/skia/SimpleFontDataSkia.cpp:145: //
m_fontMetrics.setUnderlineThickness(underlinePosition);
Can you just wait for a Skia change to land and rolled in  and do the right
thing at once instead? 

If not, how about wrapping lines 141 - 145 with "#if 0" and "#endif' instead of
prefixing with '//'.

[h.joshi, 2014-03-06 02:57:43]

Thank you, will make suggested changes and submit new patch for review.
Will follow Skia development on Blink and when Skia changes land on Blink will
upload changes.

On 2014/03/06 01:05:32, Jungshik Shin wrote:
> LGTM if you want to land this CL as it is. My preference is to wait until skia
> change is rolled in and do the right thing on Linux/Windows.
> 
>
https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
> File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> 
>
https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
> Source/platform/fonts/skia/SimpleFontDataSkia.cpp:145: //
> m_fontMetrics.setUnderlineThickness(underlinePosition);
> Can you just wait for a Skia change to land and rolled in  and do the right
> thing at once instead? 
> 
> If not, how about wrapping lines 141 - 145 with "#if 0" and "#endif' instead
of
> prefixing with '//'.

[hj, 2014-03-08 03:40:56]

Patch with comment fix.
Do we have some some mail thread or group which I can follow to know when Skia
changes are landed in Blink? Pls suggest

On 2014/03/06 02:57:43, h.joshi wrote:
> Thank you, will make suggested changes and submit new patch for review.
> Will follow Skia development on Blink and when Skia changes land on Blink will
> upload changes.
> 
> On 2014/03/06 01:05:32, Jungshik Shin wrote:
> > LGTM if you want to land this CL as it is. My preference is to wait until
skia
> > change is rolled in and do the right thing on Linux/Windows.
> > 
> >
>
https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
> > File Source/platform/fonts/skia/SimpleFontDataSkia.cpp (right):
> > 
> >
>
https://codereview.chromium.org/182923003/diff/60001/Source/platform/fonts/sk...
> > Source/platform/fonts/skia/SimpleFontDataSkia.cpp:145: //
> > m_fontMetrics.setUnderlineThickness(underlinePosition);
> > Can you just wait for a Skia change to land and rolled in  and do the right
> > thing at once instead? 
> > 
> > If not, how about wrapping lines 141 - 145 with "#if 0" and "#endif' instead
> of
> > prefixing with '//'.

[Stephen Chennney, 2014-03-10 14:40:06]

On 2014/03/08 03:40:56, hj wrote:
> Patch with comment fix.
> Do we have some some mail thread or group which I can follow to know when Skia
> changes are landed in Blink? Pls suggest

There is no mailing list for Skia rolls to Chromium (Blink uses the current
Chromium Skia revision). The best way to check is to either watch the DEPS file
for Chromium (which will pick up a lot of other changes), or manually check the
DEPS file when you are waiting on a particular revision. Right now it's at
13701.

https://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=log

[h.joshi, 2014-03-11 08:53:49]

Took new code today and Skia changes for Underline landed on Blink, will make
new patch removing "#if 0" from code.

On 2014/03/10 14:40:06, Stephen Chenney wrote:
> On 2014/03/08 03:40:56, hj wrote:
> > Patch with comment fix.
> > Do we have some some mail thread or group which I can follow to know when
Skia
> > changes are landed in Blink? Pls suggest
> 
> There is no mailing list for Skia rolls to Chromium (Blink uses the current
> Chromium Skia revision). The best way to check is to either watch the DEPS
file
> for Chromium (which will pick up a lot of other changes), or manually check
the
> DEPS file when you are waiting on a particular revision. Right now it's at
> 13701.
> 
> https://src.chromium.org/viewvc/chrome/trunk/src/DEPS?view=log

[h.joshi, 2014-03-11 09:05:01]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-03-11 09:05:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/182923003/100001

[commit-bot: I haz the power, 2014-03-11 09:22:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-11 09:22:58]

Try jobs failed on following builders: blink_presubmit

[h.joshi, 2014-03-11 09:58:48]

I tried to submit patch as LGTM was given but got following error on
blink_presubmit bot:
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:

Pls suggest

On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders: blink_presubmit

[h.joshi, 2014-03-20 10:44:22]

Pls reveiw changes, this patch required LGTM from OWNER, as on submittion I am
getting following:
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:


On 2014/03/11 09:58:48, h.joshi wrote:
> I tried to submit patch as LGTM was given but got following error on
> blink_presubmit bot:
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
> 
> Pls suggest
> 
> On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders: blink_presubmit

[h.joshi, 2014-03-20 10:45:58]

Pls review.

On 2014/03/20 10:44:22, h.joshi wrote:
> Pls reveiw changes, this patch required LGTM from OWNER, as on submittion I am
> getting following:
> ** Presubmit ERRORS **
> Missing LGTM from an OWNER for these files:
> 
> 
> On 2014/03/11 09:58:48, h.joshi wrote:
> > I tried to submit patch as LGTM was given but got following error on
> > blink_presubmit bot:
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for these files:
> > 
> > Pls suggest
> > 
> > On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> > > Try jobs failed on following builders: blink_presubmit

[jungshik at Google, 2014-04-01 20:59:44]

Can any of OWNERS review the CL?  Emil, can you review? Thanks


On 2014/03/20 10:45:58, h.joshi wrote:
> Pls review.
> 
> On 2014/03/20 10:44:22, h.joshi wrote:
> > Pls reveiw changes, this patch required LGTM from OWNER, as on submittion I
am
> > getting following:
> > ** Presubmit ERRORS **
> > Missing LGTM from an OWNER for these files:
> > 
> > 
> > On 2014/03/11 09:58:48, h.joshi wrote:
> > > I tried to submit patch as LGTM was given but got following error on
> > > blink_presubmit bot:
> > > ** Presubmit ERRORS **
> > > Missing LGTM from an OWNER for these files:
> > > 
> > > Pls suggest
> > > 
> > > On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> > > > Try jobs failed on following builders: blink_presubmit

[h.joshi, 2014-04-03 17:24:06]

Pls review patch.

On 2014/04/01 20:59:44, Jungshik Shin wrote:
> Can any of OWNERS review the CL?  Emil, can you review? Thanks
> 
> 
> On 2014/03/20 10:45:58, h.joshi wrote:
> > Pls review.
> > 
> > On 2014/03/20 10:44:22, h.joshi wrote:
> > > Pls reveiw changes, this patch required LGTM from OWNER, as on submittion
I
> am
> > > getting following:
> > > ** Presubmit ERRORS **
> > > Missing LGTM from an OWNER for these files:
> > > 
> > > 
> > > On 2014/03/11 09:58:48, h.joshi wrote:
> > > > I tried to submit patch as LGTM was given but got following error on
> > > > blink_presubmit bot:
> > > > ** Presubmit ERRORS **
> > > > Missing LGTM from an OWNER for these files:
> > > > 
> > > > Pls suggest
> > > > 
> > > > On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> > > > > Try jobs failed on following builders: blink_presubmit

[h.joshi, 2014-04-04 12:53:15]

Pls review this patch, its pending for long time now.


On 2014/04/03 17:24:06, h.joshi wrote:
> Pls review patch.
> 
> On 2014/04/01 20:59:44, Jungshik Shin wrote:
> > Can any of OWNERS review the CL?  Emil, can you review? Thanks
> > 
> > 
> > On 2014/03/20 10:45:58, h.joshi wrote:
> > > Pls review.
> > > 
> > > On 2014/03/20 10:44:22, h.joshi wrote:
> > > > Pls reveiw changes, this patch required LGTM from OWNER, as on
submittion
> I
> > am
> > > > getting following:
> > > > ** Presubmit ERRORS **
> > > > Missing LGTM from an OWNER for these files:
> > > > 
> > > > 
> > > > On 2014/03/11 09:58:48, h.joshi wrote:
> > > > > I tried to submit patch as LGTM was given but got following error on
> > > > > blink_presubmit bot:
> > > > > ** Presubmit ERRORS **
> > > > > Missing LGTM from an OWNER for these files:
> > > > > 
> > > > > Pls suggest
> > > > > 
> > > > > On 2014/03/11 09:22:58, I haz the power (commit-bot) wrote:
> > > > > > Try jobs failed on following builders: blink_presubmit

[eseidel, 2014-04-08 05:44:26]

Emil or Levi are your best reviewers here.

[eseidel, 2014-04-08 05:45:35]

Do we have tests for this?  Do our new results match other browsers?

[eseidel, 2014-04-08 05:46:11]

Could you explain in the CL description approximately what tests this affects? 
Is this covered by 1 test or 1000?  How many other browsers respect this?

[eseidel, 2014-04-08 05:48:00]

lgtm

Based on the previous reviews of this change, lgtm.  Emil and Levi are both CC'd
and can comment furhter if necessary.

[commit-bot: I haz the power, 2014-04-08 05:48:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/182923003/100001

[commit-bot: I haz the power, 2014-04-08 05:48:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-08 05:48:24]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[h.joshi, 2014-04-08 06:06:00]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-04-08 06:06:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/182923003/100001

[commit-bot: I haz the power, 2014-04-08 06:07:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-08 06:07:21]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[Dominik Röttsches, 2014-04-08 08:27:16]

On 2014/04/08 06:07:21, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on linux_blink_rel

Looks like in many of the failing tests the underline-stroke is now very thin
compared to the previous behaviour. Is that intended?

[h.joshi, 2014-04-08 08:56:05]

With this patch, we are taking Underline thickness and position from Font
Metrics.
Initially Skia was not supporting these values from Font and we had static
calculation code in Blink.


On 2014/04/08 08:27:16, Dominik Röttsches wrote:
> On 2014/04/08 06:07:21, I haz the power (commit-bot) wrote:
> > Try jobs failed on following builders:
> >   tryserver.blink on linux_blink_rel
> 
> Looks like in many of the failing tests the underline-stroke is now very thin
> compared to the previous behaviour. Is that intended?

[h.joshi, 2014-04-08 08:56:22]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-04-08 08:56:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/182923003/120001

[commit-bot: I haz the power, 2014-04-08 08:56:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-08 08:56:51]

Failed to apply patch for LayoutTests/TestExpectations:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file LayoutTests/TestExpectations
  Hunk #1 FAILED at 931.
  1 out of 1 hunk FAILED -- saving rejects to file
LayoutTests/TestExpectations.rej

Patch:       LayoutTests/TestExpectations
Index: LayoutTests/TestExpectations
diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations
index
b4d0043bab2d11cda585a64bcbb6dd5b4e8e31e5..fc312e801a8970bb9140900a3e9bad5264c29b8f
100644
--- a/LayoutTests/TestExpectations
+++ b/LayoutTests/TestExpectations
@@ -931,3 +931,57 @@ crbug.com/353754 fast/scrolling/hover-during-scroll.html [
Pass Failure ]
 crbug.com/353770 [ Linux ]
media/encrypted-media/encrypted-media-playback-setmediakeys-after-src.html [
Pass Failure Timeout ]
 crbug.com/353790 [ Linux Win ] virtual/threaded/animations/import.html [ Pass
Timeout ]
 crbug.com/353792 media/encrypted-media/encrypted-media-waiting-for-a-key.html [
Pass Failure Crash ]
+
+# Way to Underline position code changed, need to rebase files after
https://codereview.chromium.org/182923003/ .
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/international/rtl-white-space-pre-wrap.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-4038267-fix.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-008.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/repaint/shadow-multiple-strict-vertical.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/float/centered-float-avoidance-complexity.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
http/tests/misc/acid2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
ietestcenter/css3/text/textshadow-002.htm [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/line-breaks.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-text-019.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-001.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/float/float-in-float-painting.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/style/block-styles-007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
tables/mozilla/bugs/bug128229.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/positioning/auto/vertical-rl/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/repaint/shadow-multiple-strict-horizontal.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-004.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-006.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/return-key-with-selection-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/positioning/auto/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
svg/custom/svg-fonts-without-missing-glyph.xhtml [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/positioning/auto/vertical-lr/007.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/stroking-decorations.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-023.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/style/style-3998892-fix.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/return-key-with-selection-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/repaint/shadow-multiple-horizontal.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-match-style-002.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css/acid2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/block/float/float-in-float-hit-testing.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style.html [
NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css/clip-zooming.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-010.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/trailing-white-space.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-022.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-005.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/pasteboard/paste-line-endings-009.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css3-text/css3-text-decoration/text-decoration-style.html [ NeedsRebaseline
]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/style/smoosh-styles-003.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/decorations-with-text-combine.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css/line-thickness-underline-strikethrough-overline.html [ NeedsRebaseline
]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/dom/clone-node-dynamic-style.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/repaint/shadow-multiple-vertical.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/text/trailing-white-space-2.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css/first-line-text-decoration-inherited-from-parent.html [ NeedsRebaseline
]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
fast/css/first-line-text-decoration.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/return-key-with-selection-001.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-024.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/inserting/insert-div-026.html [ NeedsRebaseline ]
+crbug.com/347510 [ Linux Mac Mavericks SnowLeopard Lion MountainLion Retina ]
editing/deleting/delete-4083333-fix.html [ NeedsRebaseline ]

[h.joshi, 2014-04-08 10:39:46]

The CQ bit was checked by h.joshi@samsung.com

[commit-bot: I haz the power, 2014-04-08 10:39:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/h.joshi@samsung.com/182923003/140001

[commit-bot: I haz the power, 2014-04-08 10:42:10]

Change committed as 171050