Chrome not considering Underline Position from Font

Source/platform/fonts/skia/SimpleFontDataSkia.cpp

 /*
  * Copyright (c) 2008, 2009, Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 115 matching lines @@
     } else {
         xHeight = ascent * 0.56; // Best guess from Windows font metrics.
         m_fontMetrics.setXHeight(xHeight);
         m_fontMetrics.setHasXHeight(false);
     }
 
     float lineGap = SkScalarToFloat(metrics.fLeading);
     m_fontMetrics.setLineGap(lineGap);
     m_fontMetrics.setLineSpacing(lroundf(ascent) + lroundf(descent) + lroundf(lineGap));
 
-    // For now Skia does not support underline Thickness, once patch is comitted we can uncomment following
-    // code, till then setting Underline Thickness to Zero so that default calculation is done.
+    // For now Skia does not support underline Thickness and Position, once submitted patch is comitted
+    // we can uncomment following code, till then setting Underline Thickness and Position to Zero so that
+    // default calculation is done.

[eae, 2014/02/28 17:37:59]

Could you add a FIXME comment with a link to the bug in question?

[h.joshi, 2014/03/01 03:36:12]

Will add FIXME comment in next patch.

On 2014/02/28 17:37:59, eae wrote:

+
     // float underlineThickness = SkScalarToFloat(metrics.fUnderlineThickness);
     // m_fontMetrics.setUnderlineThickness(underlineThickness);
+
+    // float underlinePosition = SkScalarToFloat(metrics.fUnderlinePosition);
+    // m_fontMetrics.setUnderlineThickness(underlinePosition);
     m_fontMetrics.setUnderlineThickness(0.f);
+    m_fontMetrics.setUnderlinePosition(0.f);
 
     if (platformData().orientation() == Vertical && !isTextOrientationFallback()) {
         static const uint32_t vheaTag = SkSetFourByteTag('v', 'h', 'e', 'a');
         static const uint32_t vorgTag = SkSetFourByteTag('V', 'O', 'R', 'G');
         size_t vheaSize = face->getTableSize(vheaTag);
         size_t vorgSize = face->getTableSize(vorgTag);
         if ((vheaSize > 0) || (vorgSize > 0))
             m_hasVerticalGlyphs = true;
     }
 
@@ skipping 125 matching lines @@
     paint.setTextEncoding(SkPaint::kUTF16_TextEncoding);
     if (paint.textToGlyphs(&normalizedCharacters[0], normalizedLength * 2, 0)) {
         addResult.storedValue->value = true;
         return true;
     }
     return false;
 }
 #endif
 
 } // namespace WebCore