Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Unified Diff: Source/platform/fonts/FontMetrics.h

Issue 182923003: Chrome not considering Underline Position from Font (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixing TestExpectation Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/platform/fonts/mac/SimpleFontDataMac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/platform/fonts/FontMetrics.h
diff --git a/Source/platform/fonts/FontMetrics.h b/Source/platform/fonts/FontMetrics.h
index 2bfa54e75118b6e1e9e7266ccf6308f69ad5a07f..1d4ff32593f0e05d10b299b31d958c225cbcc7bd 100644
--- a/Source/platform/fonts/FontMetrics.h
+++ b/Source/platform/fonts/FontMetrics.h
@@ -38,6 +38,7 @@ public:
, m_xHeight(0)
, m_zeroWidth(0)
, m_underlinethickness(0)
+ , m_underlinePosition(0)
, m_hasXHeight(false)
, m_hasZeroWidth(false)
{
@@ -126,6 +127,9 @@ public:
float underlineThickness() const { return m_underlinethickness; }
void setUnderlineThickness(float underlineThickness) { m_underlinethickness = underlineThickness; }
+ float underlinePosition() const { return m_underlinePosition; }
+ void setUnderlinePosition(float underlinePosition) { m_underlinePosition = underlinePosition; }
+
private:
friend class SimpleFontData;
@@ -139,6 +143,7 @@ private:
m_xHeight = 0;
m_hasXHeight = false;
m_underlinethickness = 0;
+ m_underlinePosition = 0;
}
unsigned m_unitsPerEm;
@@ -149,6 +154,7 @@ private:
float m_xHeight;
float m_zeroWidth;
float m_underlinethickness;
+ float m_underlinePosition;
bool m_hasXHeight;
bool m_hasZeroWidth;
};
« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/platform/fonts/mac/SimpleFontDataMac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698