third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/graphics/GraphicsContextState.cpp ('K') | « third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SourceAlpha.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

index 850ae4673569a34bf3f1ac8371f533be21ea7414..602731de1c91087b853bd5e3a06596398f196e73 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FilterEffect.cpp

@@ -210,9 +210,9 @@ bool FilterEffect::inputsTaintOrigin() const

PassRefPtr<SkImageFilter> FilterEffect::createTransparentBlack(SkiaImageFilterBuilder& builder) const

{

- SkAutoTUnref<SkColorFilter> filter(SkColorFilter::CreateModeFilter(0, SkXfermode::kClear_Mode));

SkImageFilter::CropRect rect = getCropRect();

- return adoptRef(SkColorFilterImageFilter::Create(filter, nullptr, &rect));

+ sk_sp<SkColorFilter> colorFilter = SkColorFilter::MakeModeFilter(0, SkXfermode::kClear_Mode);

+ return adoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), nullptr, &rect));

}

bool FilterEffect::hasConnectedInput() const