third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp - Issue 1829093002: Use sk_sp-based APIs for SkColorFilter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp

Issue 1829093002: Use sk_sp-based APIs for SkColorFilter (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Respond to reviews Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp b/third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp

index 7dd0d89d371fe1844e7b25c9f35b0eb9b83ede36..050feb32058bb2f28c66d93d09caf5eacd801d21 100644

--- a/third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp

+++ b/third_party/WebKit/Source/platform/graphics/filters/FEFlood.cpp

@@ -74,8 +74,8 @@ PassRefPtr<SkImageFilter> FEFlood::createImageFilter(SkiaImageFilterBuilder& bui

Color color = floodColor().combineWithAlpha(floodOpacity());

SkImageFilter::CropRect rect = getCropRect();

- SkAutoTUnref<SkColorFilter> cf(SkColorFilter::CreateModeFilter(color.rgb(), SkXfermode::kSrc_Mode));

- return adoptRef(SkColorFilterImageFilter::Create(cf, 0, &rect));

+ sk_sp<SkColorFilter> colorFilter = SkColorFilter::MakeModeFilter(color.rgb(), SkXfermode::kSrc_Mode);

+ return adoptRef(SkColorFilterImageFilter::Create(colorFilter.get(), 0, &rect));

}

TextStream& FEFlood::externalRepresentation(TextStream& ts, int indent) const