[Extensions] Convert APIs to use movable types [3]

[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
Committed: https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682
Cr-Commit-Position: refs/heads/master@{#383142}

[Devlin, 2016-03-23 14:26:15]

Description was changed from

==========
[Extensions] Convert APIs to use movable types []

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
==========

[Devlin, 2016-03-23 14:43:23]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-03-23 16:45:31]

rdevlin.cronin@chromium.org changed reviewers:
+ asargent@chromium.org

[Devlin, 2016-03-23 16:45:31]

(all of these should be independent of one another.)

[asargent_no_longer_on_chrome, 2016-03-23 19:54:25]

lgtm

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/cookies/cookies_helpers.h (right):

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/cookies/cookies_helpers.h:48: // Allocates and
construct a new Cookie object representing a cookie as defined
"construct" should be "constructs", and I suppose the "allocates" part isn't as
clearly correct, so maybe it should just be "Constructs a new Cookie ...."

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/cookies/cookies_helpers.h:53: // Allocates and
constructs a new CookieStore object as defined by the cookies
same thing here re:Allocates

[Devlin, 2016-03-24 19:57:57]

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/api/cookies/cookies_helpers.h (right):

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/cookies/cookies_helpers.h:48: // Allocates and
construct a new Cookie object representing a cookie as defined
On 2016/03/23 19:54:25, Antony Sargent wrote:
> "construct" should be "constructs", and I suppose the "allocates" part isn't
as
> clearly correct, so maybe it should just be "Constructs a new Cookie ...."

Done.

https://codereview.chromium.org/1828683002/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/api/cookies/cookies_helpers.h:53: // Allocates and
constructs a new CookieStore object as defined by the cookies
On 2016/03/23 19:54:25, Antony Sargent wrote:
> same thing here re:Allocates

Done.

[Devlin, 2016-03-24 19:58:02]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-03-24 19:58:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
asargent@chromium.org
Link to the patchset: https://codereview.chromium.org/1828683002/#ps40001
(title: "Antony's")

[commit-bot: I haz the power, 2016-03-24 19:58:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1828683002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1828683002/40001

[commit-bot: I haz the power, 2016-03-24 20:52:25]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
==========

[commit-bot: I haz the power, 2016-03-24 20:52:27]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-03-24 20:54:11]

Description was changed from

==========
[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949
==========

to

==========
[Extensions] Convert APIs to use movable types [3]

Generated extensions code used to rely on linked_ptrs for non-copyable types in
containers. Now, we can make these types movable. Update the following APIs
to use movable types in this CL:
- browser.idl
- browsing_data.json
- cast_devices_private.idl
- cast_streaming_receiver_session.idl
- cast_streaming_rtp_stream.idl
- cast_streaming_session.idl
- cast_streaming_udp_transport.idl
- certificate_provider.idl
- certificate_provider_internal.idl
- chrome_web_view_internal.json
- chromeos_info_private.json
- cloud_print_private.json
- command_line_private.json
- commands.json
- content_settings.json
- context_menus.json
- context_menus_internal.json
- cookies.json
- copresence.idl
- copresence_private.idl

BUG=595949

Committed: https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682
Cr-Commit-Position: refs/heads/master@{#383142}
==========

[commit-bot: I haz the power, 2016-03-24 20:54:13]

Patchset 2 (id:??) landed as
https://crrev.com/1cb4c0e1be53447096ae11f820bb408b71184682
Cr-Commit-Position: refs/heads/master@{#383142}