chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc - Issue 1828683002: [Extensions] Convert APIs to use movable types [3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

Issue 1828683002: [Extensions] Convert APIs to use movable types [3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Antony's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc ('k') | chrome/browser/extensions/api/cookies/cookies_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

diff --git a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

index 47dc8974a53eb853ba364485b49182fd8f8d47f5..7e44909abf4988f0a381ba51cdf49948bb35b61a 100644

--- a/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

+++ b/chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc

@@ -79,12 +79,11 @@ class CloudPrintTestsDelegateMock : public extensions::CloudPrintTestsDelegate {

MATCHER(IsExpectedUserSettings, "") {

const UserSettings& settings = arg;

- return settings.connect_new_printers &&

- settings.printers.size() == 2 &&

- settings.printers[0]->name == "printer1" &&

- !settings.printers[0]->connect &&

- settings.printers[1]->name == "printer2" &&

- settings.printers[1]->connect;

+ return settings.connect_new_printers && settings.printers.size() == 2 &&

+ settings.printers[0].name == "printer1" &&

+ !settings.printers[0].connect &&

+ settings.printers[1].name == "printer2" &&

+ settings.printers[1].connect;

}

// http://crbug.com/177163