chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc - Issue 1828683002: [Extensions] Convert APIs to use movable types [3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

Issue 1828683002: [Extensions] Convert APIs to use movable types [3] (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Antony's Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/cast_devices_private/cast_devices_private_api.cc ('k') | chrome/browser/extensions/api/cloud_print_private/cloud_print_private_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

diff --git a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

index 98c9627997c6cda5b9c9fbd063d0f47e1061627e..a4f4c3ee5269ebc5c7606bcddf6fe9fc707b58b7 100644

--- a/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

+++ b/chrome/browser/extensions/api/certificate_provider/certificate_provider_api.cc

@@ -10,7 +10,6 @@

#include <vector>

#include "base/logging.h"

-#include "base/memory/linked_ptr.h"

#include "base/memory/scoped_ptr.h"

#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service.h"

#include "chrome/browser/chromeos/certificate_provider/certificate_provider_service_factory.h"

@@ -59,14 +58,13 @@ CertificateProviderInternalReportCertificatesFunction::Run() {

chromeos::certificate_provider::CertificateInfoList cert_infos;

std::vector<std::vector<char>> rejected_certificates;

- for (linked_ptr<api_cp::CertificateInfo> input_cert_info :

- *params->certificates) {

+ for (const api_cp::CertificateInfo& input_cert_info : *params->certificates) {

chromeos::certificate_provider::CertificateInfo parsed_cert_info;

- if (ParseCertificateInfo(*input_cert_info, &parsed_cert_info))

+ if (ParseCertificateInfo(input_cert_info, &parsed_cert_info))

cert_infos.push_back(parsed_cert_info);

else

- rejected_certificates.push_back(input_cert_info->certificate);

+ rejected_certificates.push_back(input_cert_info.certificate);

}

if (service->SetCertificatesProvidedByExtension(