Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Issue 1828023002: [DevTools] Remove obsolete check from V8DebuggerImpl::currentCallFrames() (Closed)

Created:
4 years, 9 months ago by kozy
Modified:
4 years, 9 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, tfarina, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, kinuko+watch, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Remove obsolete check from V8DebuggerImpl::currentCallFrames() This check was introduced in https://codereview.chromium.org/374903002 1 year and 8 months ago then 8 months ago Yang landed V8 patch: https://codereview.chromium.org/1216193002. With this patch ExecutionState.frame report only not internal frames. We use this method for getting callframes in V8DebuggerImpl::currentCallFrames function. BUG=595206 R=dgozman@chromium.org Committed: https://crrev.com/6e21aab027a4c54a2763e05c52e3ad5956d36500 Cr-Commit-Position: refs/heads/master@{#382991}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -15 lines) Patch
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8DebuggerImpl.cpp View 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
kozy
Dmitry, please take a look!
4 years, 9 months ago (2016-03-23 22:19:27 UTC) #3
kozy
Updated description. Please take a look!
4 years, 9 months ago (2016-03-23 23:03:01 UTC) #5
dgozman
lgtm
4 years, 9 months ago (2016-03-23 23:13:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1828023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1828023002/20001
4 years, 9 months ago (2016-03-23 23:14:23 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 9 months ago (2016-03-24 00:34:30 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-24 00:38:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e21aab027a4c54a2763e05c52e3ad5956d36500
Cr-Commit-Position: refs/heads/master@{#382991}

Powered by Google App Engine
This is Rietveld 408576698