DevTools: Async call stacks for Promises and Object.observe.

DevTools: Async call stacks for Promises and Object.observe.

BUG=272416, 356567
R=yurys, pfeldman@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=177873

[aandrey, 2014-07-10 06:13:12]

Ping?

[yurys, 2014-07-10 12:24:29]

lgtm

https://codereview.chromium.org/374903002/diff/40001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptDebugServer.cpp (right):

https://codereview.chromium.org/374903002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptDebugServer.cpp:520: if (name ==
"Promise.Resolved")
Why do we need it in the new code at the first place?

[aandrey, 2014-07-10 12:25:54]

https://codereview.chromium.org/374903002/diff/40001/Source/bindings/core/v8/...
File Source/bindings/core/v8/ScriptDebugServer.cpp (right):

https://codereview.chromium.org/374903002/diff/40001/Source/bindings/core/v8/...
Source/bindings/core/v8/ScriptDebugServer.cpp:520: if (name ==
"Promise.Resolved")
On 2014/07/10 12:24:28, yurys wrote:
> Why do we need it in the new code at the first place?

Yeah, I was confused with the names. I committed the fix to V8 already.

[aandrey, 2014-07-10 12:25:57]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-10 12:27:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/374903002/40001

[commit-bot: I haz the power, 2014-07-10 12:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 12:27:19]

Failed to apply patch for Source/core/inspector/AsyncCallStackTracker.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/inspector/AsyncCallStackTracker.cpp
  Hunk #1 succeeded at 40 (offset 1 line).
  Hunk #2 FAILED at 81.
  Hunk #3 succeeded at 326 (offset 30 lines).
  Hunk #4 succeeded at 361 (offset 30 lines).
  Hunk #5 succeeded at 400 (offset 30 lines).
  1 out of 5 hunks FAILED -- saving rejects to file
Source/core/inspector/AsyncCallStackTracker.cpp.rej

Patch:       Source/core/inspector/AsyncCallStackTracker.cpp
Index: Source/core/inspector/AsyncCallStackTracker.cpp
diff --git a/Source/core/inspector/AsyncCallStackTracker.cpp
b/Source/core/inspector/AsyncCallStackTracker.cpp
index
7c0da5d6e30a0e62d722ce88d5e4d3fb2fb62591..2ea60676f6ac7f85786ebde6dd140daac66ee6db
100644
--- a/Source/core/inspector/AsyncCallStackTracker.cpp
+++ b/Source/core/inspector/AsyncCallStackTracker.cpp
@@ -39,8 +39,8 @@
 #include "core/events/EventTarget.h"
 #include "core/xml/XMLHttpRequest.h"
 #include "core/xml/XMLHttpRequestUpload.h"
-#include "wtf/text/AtomicStringHash.h"
 #include "wtf/text/StringBuilder.h"
+#include "wtf/text/StringHash.h"
 #include <v8.h>
 
 namespace {
@@ -81,6 +81,7 @@ public:
     HashMap<Event*, RefPtr<AsyncCallChain> > m_eventCallChains;
     HashMap<EventTarget*, RefPtr<AsyncCallChain> > m_xhrCallChains;
     HashMap<MutationObserver*, RefPtr<AsyncCallChain> >
m_mutationObserverCallChains;
+    HashMap<String, RefPtr<AsyncCallChain> > m_v8AsyncTaskCallChains;
 };
 
 static XMLHttpRequest* toXmlHttpRequest(EventTarget* eventTarget)
@@ -296,6 +297,34 @@ void
AsyncCallStackTracker::willDeliverMutationRecords(ExecutionContext* context
         setCurrentAsyncCallChain(context, nullptr);
 }
 
+static String makeV8AsyncTaskUniqueId(const String& eventName, int id)
+{
+    StringBuilder builder;
+    builder.append(eventName);
+    builder.appendNumber(id);
+    return builder.toString();
+}
+
+void AsyncCallStackTracker::didEnqueueV8AsyncTask(ExecutionContext* context,
const String& eventName, int id, const ScriptValue& callFrames)
+{
+    ASSERT(context);
+    ASSERT(isEnabled());
+    if (!validateCallFrames(callFrames))
+        return;
+    ExecutionContextData* data = createContextDataIfNeeded(context);
+    data->m_v8AsyncTaskCallChains.set(makeV8AsyncTaskUniqueId(eventName, id),
createAsyncCallChain(eventName, callFrames));
+}
+
+void AsyncCallStackTracker::willHandleV8AsyncTask(ExecutionContext* context,
const String& eventName, int id)
+{
+    ASSERT(context);
+    ASSERT(isEnabled());
+    if (ExecutionContextData* data = m_executionContextDataMap.get(context))
+        setCurrentAsyncCallChain(context,
data->m_v8AsyncTaskCallChains.take(makeV8AsyncTaskUniqueId(eventName, id)));
+    else
+        setCurrentAsyncCallChain(context, nullptr);
+}
+
 void AsyncCallStackTracker::didFireAsyncCall()
 {
     clearCurrentAsyncCallChain();
@@ -303,6 +332,10 @@ void AsyncCallStackTracker::didFireAsyncCall()
 
 PassRefPtr<AsyncCallStackTracker::AsyncCallChain>
AsyncCallStackTracker::createAsyncCallChain(const String& description, const
ScriptValue& callFrames)
 {
+    if (callFrames.isEmpty()) {
+        ASSERT(m_currentAsyncCallChain);
+        return m_currentAsyncCallChain; // Propogate async call stack chain.
+    }
     RefPtr<AsyncCallChain> chain = adoptRef(m_currentAsyncCallChain ? new
AsyncCallStackTracker::AsyncCallChain(*m_currentAsyncCallChain) : new
AsyncCallStackTracker::AsyncCallChain());
     ensureMaxAsyncCallChainDepth(chain.get(), m_maxAsyncCallStackDepth - 1);
     chain->m_callStacks.prepend(adoptRef(new
AsyncCallStackTracker::AsyncCallStack(description, callFrames)));
@@ -338,7 +371,7 @@ void
AsyncCallStackTracker::ensureMaxAsyncCallChainDepth(AsyncCallChain* chain,
 
 bool AsyncCallStackTracker::validateCallFrames(const ScriptValue& callFrames)
 {
-    return !callFrames.isEmpty();
+    return !callFrames.isEmpty() || m_currentAsyncCallChain;
 }
 
 AsyncCallStackTracker::ExecutionContextData*
AsyncCallStackTracker::createContextDataIfNeeded(ExecutionContext* context)

[aandrey, 2014-07-10 13:32:31]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-10 13:33:40]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/374903002/60001

[commit-bot: I haz the power, 2014-07-10 14:34:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16247)

[commit-bot: I haz the power, 2014-07-10 15:39:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 15:39:37]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16256)

[aandrey, 2014-07-10 15:45:03]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-10 15:45:48]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/374903002/60001

[aandrey, 2014-07-10 16:06:54]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-10 16:07:00]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/374903002/60001

[commit-bot: I haz the power, 2014-07-10 17:23:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16273)

[commit-bot: I haz the power, 2014-07-10 18:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-10 18:28:50]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16284)

[aandrey, 2014-07-10 18:30:00]

The CQ bit was checked by aandrey@chromium.org

[commit-bot: I haz the power, 2014-07-10 18:30:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/aandrey@chromium.org/374903002/60001

[commit-bot: I haz the power, 2014-07-10 19:14:45]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/16302)

[commit-bot: I haz the power, 2014-07-10 19:44:50]

Change committed as 177873