Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1216193002: Debugger: ensure that break points are set in code that contain debug break slots. (Closed)

Created:
5 years, 5 months ago by Yang
Modified:
5 years, 5 months ago
Reviewers:
mvstanton
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: ensure that break points are set in code that contain debug break slots. We now consistently ignore native and extension scripts for debugging. Only native scripts and extension scripts can disallow lazy compilation. So we can make sure that break points are only set to code that are compiled with debug break slots. R=mvstanton@chromium.org Committed: https://crrev.com/77d566c06728ba9aa1a3aa339218ce317c330966 Cr-Commit-Position: refs/heads/master@{#29400}

Patch Set 1 #

Patch Set 2 : assert that break points are always set in code that has debug break slots #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -14 lines) Patch
M src/debug.cc View 1 5 chunks +12 lines, -8 lines 0 comments Download
M src/isolate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/objects-inl.h View 1 chunk +5 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Yang
5 years, 5 months ago (2015-06-30 11:32:43 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216193002/1
5 years, 5 months ago (2015-06-30 11:33:45 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-06-30 12:01:01 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216193002/20001
5 years, 5 months ago (2015-06-30 12:03:30 UTC) #7
mvstanton
Cool, I like the wrapping up of two predicates into IsSubjectToDebugging(). LGTM.
5 years, 5 months ago (2015-07-01 07:54:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1216193002/20001
5 years, 5 months ago (2015-07-01 07:59:36 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-07-01 08:01:19 UTC) #12
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 08:01:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/77d566c06728ba9aa1a3aa339218ce317c330966
Cr-Commit-Position: refs/heads/master@{#29400}

Powered by Google App Engine
This is Rietveld 408576698