Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Issue 1827693002: Revert of Fix PRIMITIVE_RESTART_FIXED_INDEX handling in command buffer and WebGL 2.0. (Closed)

Created:
4 years, 9 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, piman+watch_chromium.org, yunchao, qiankun
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix PRIMITIVE_RESTART_FIXED_INDEX handling in command buffer and WebGL 2.0. (patchset #4 id:60001 of https://codereview.chromium.org/1813163003/ ) Reason for revert: Broke WebGL 2.0 conformance tests on Mac OS X. Needs https://codereview.chromium.org/1822643002 and possibly more. Original issue's description: > Fix PRIMITIVE_RESTART_FIXED_INDEX handling in command buffer and WebGL 2.0. > > Adapted from yunchao.he@intel.com's > https://codereview.chromium.org/1783763002 . > > This fixes the command buffer's index validation and WebGL 2.0's > implicit enabling of this capability. Emulation of this feature on top > of earlier desktop OpenGL versions will be implemented in a later CL. > > BUG=594021, 295792 > TEST=deqp/functional/gles3/primitiverestart.html > CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/0b677e15ebe36546b0d946af78657be3d8b3f0b0 > Cr-Commit-Position: refs/heads/master@{#382497} TBR=zmo@chromium.org,bajones@chromium.org,piman@chromium.org,yunchao.he@intel.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=594021, 295792 Committed: https://crrev.com/557d64542a3d0eda9c8f4cbd445a9ecfd88c8622 Cr-Commit-Position: refs/heads/master@{#382742}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -253 lines) Patch
M gpu/command_buffer/service/buffer_manager.h View 4 chunks +4 lines, -10 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager.cc View 3 chunks +6 lines, -53 lines 0 comments Download
M gpu/command_buffer/service/buffer_manager_unittest.cc View 5 chunks +115 lines, -170 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 chunks +2 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ken Russell (switch to Gerrit)
Created Revert of Fix PRIMITIVE_RESTART_FIXED_INDEX handling in command buffer and WebGL 2.0.
4 years, 9 months ago (2016-03-23 00:13:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827693002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827693002/1
4 years, 9 months ago (2016-03-23 00:14:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 00:14:46 UTC) #4
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 00:15:59 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/557d64542a3d0eda9c8f4cbd445a9ecfd88c8622
Cr-Commit-Position: refs/heads/master@{#382742}

Powered by Google App Engine
This is Rietveld 408576698