Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 182753002: Revert of Use the default dispatcher where possible for nested message loops. (Closed)

Created:
6 years, 9 months ago by scottmg
Modified:
6 years, 9 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Revert of Use the default dispatcher where possible for nested message loops. (https://codereview.chromium.org/182143002/) Reason for revert: win debug interactive_ui_tests: BookmarkBarViewTest12.CloseWithModalDialog (run #1): [ RUN ] BookmarkBarViewTest12.CloseWithModalDialog [3940:2156:0226/224958:2493504:FATAL:desktop_dispatcher_client.cc(33)] Check failed: !quit_closure_.is_null(). Original issue's description: > Use the default dispatcher where possible for nested message loops. > > Notable changes: > * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to > terminate a nested loop started by RunWithDispatcher(). > * FirstRunDialog and SimpleMessageBoxViews are no longer > MessagePumpDispatchers. The default dispatcher is used instead, and > QuitNestedMessageLoop() is called to terminate the loop instead of returning > POST_DISPATCH_QUIT_LOOP from the Dispatch() override. > > BUG=none > R=sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253723 TBR=sky@chromium.org,sadrul@chromium.org NOTREECHECKS=true NOTRY=true BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=253744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -78 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.h View 4 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 8 chunks +20 lines, -14 lines 0 comments Download
M ui/aura/client/dispatcher_client.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 2 chunks +8 lines, -14 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scottmg
Created Revert of Use the default dispatcher where possible for nested message loops.
6 years, 9 months ago (2014-02-27 07:45:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scottmg@chromium.org/182753002/1
6 years, 9 months ago (2014-02-27 07:46:23 UTC) #2
commit-bot: I haz the power
6 years, 9 months ago (2014-02-27 07:47:13 UTC) #3
Message was sent while issue was closed.
Change committed as 253744

Powered by Google App Engine
This is Rietveld 408576698