Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 182143002: Use the default dispatcher where possible for nested message loops. (Closed)

Created:
6 years, 10 months ago by sadrul
Modified:
6 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, ben+aura_chromium.org, tfarina, kalyank, ben+views_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Use the default dispatcher where possible for nested message loops. Notable changes: * Add QuitNestedMessageLoop() to client::DispatcherClient, which can be used to terminate a nested loop started by RunWithDispatcher(). * FirstRunDialog and SimpleMessageBoxViews are no longer MessagePumpDispatchers. The default dispatcher is used instead, and QuitNestedMessageLoop() is called to terminate the loop instead of returning POST_DISPATCH_QUIT_LOOP from the Dispatch() override. BUG=none R=sky@chromium.org Previously committed in r253723, but reverted in r253744 because it broke interactive_ui_tests on win-dbg. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=254089

Patch Set 1 : . #

Patch Set 2 : revert #

Patch Set 3 : fix-win-dbg-interactive-ui-test #

Patch Set 4 : moar-fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -54 lines) Patch
M ash/accelerators/accelerator_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_dispatcher.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ash/accelerators/nested_dispatcher_controller.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.h View 4 chunks +5 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 6 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/simple_message_box_views.cc View 1 2 3 9 chunks +23 lines, -20 lines 0 comments Download
M ui/aura/client/dispatcher_client.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 1 2 3 2 chunks +14 lines, -8 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.h View 2 chunks +4 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_dispatcher_client.cc View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sadrul
6 years, 10 months ago (2014-02-27 00:05:16 UTC) #1
sky
LGTM
6 years, 10 months ago (2014-02-27 00:30:54 UTC) #2
sadrul
Committed patchset #1 manually as r253723 (tree was closed).
6 years, 10 months ago (2014-02-27 05:23:23 UTC) #3
scottmg
A revert of this CL has been created in https://codereview.chromium.org/182753002/ by scottmg@chromium.org. The reason for ...
6 years, 9 months ago (2014-02-27 07:45:47 UTC) #4
sadrul
On 2014/02/27 07:45:47, scottmg wrote: > A revert of this CL has been created in ...
6 years, 9 months ago (2014-02-27 22:19:55 UTC) #5
sky
LGTM
6 years, 9 months ago (2014-02-27 23:17:47 UTC) #6
sadrul
6 years, 9 months ago (2014-02-28 10:41:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 manually as r254089 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698