Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1827523005: [turbofan] Reduce boilerplate around HeapNumber allocation in stubs. (Closed)

Created:
4 years, 9 months ago by Benedikt Meurer
Modified:
4 years, 9 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Reduce boilerplate around HeapNumber allocation in stubs. R=jarin@chromium.org Committed: https://crrev.com/41450ffd7e396491b7e2780bd4d4bb3647b9d7c8 Cr-Commit-Position: refs/heads/master@{#35012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -31 lines) Patch
M src/builtins.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/code-stubs.cc View 3 chunks +10 lines, -25 lines 0 comments Download
M src/compiler/code-stub-assembler.h View 1 chunk +5 lines, -1 line 0 comments Download
M src/compiler/code-stub-assembler.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Benedikt Meurer
4 years, 9 months ago (2016-03-23 05:27:39 UTC) #1
Benedikt Meurer
Hey Jaro, Simple refactoring. Please take a look. Thanks, Benedikt
4 years, 9 months ago (2016-03-23 05:28:31 UTC) #2
Jarin
lgtm
4 years, 9 months ago (2016-03-23 05:30:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827523005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827523005/1
4 years, 9 months ago (2016-03-23 05:30:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-23 06:14:42 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-03-23 06:17:06 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/41450ffd7e396491b7e2780bd4d4bb3647b9d7c8
Cr-Commit-Position: refs/heads/master@{#35012}

Powered by Google App Engine
This is Rietveld 408576698