[turbofan] Reduce boilerplate around HeapNumber allocation in stubs.

src/code-stubs.cc

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 
 #include <sstream>
 
 #include "src/bootstrapper.h"
 #include "src/code-factory.h"
@@ skipping 447 matching lines @@
   Zone zone;
   CallInterfaceDescriptor descriptor(GetCallInterfaceDescriptor());
   compiler::CodeStubAssembler assembler(isolate(), &zone, descriptor,
                                         GetCodeFlags(), name);
   GenerateAssembly(&assembler);
   return assembler.GenerateCode();
 }
 
 void AllocateHeapNumberStub::GenerateAssembly(
     compiler::CodeStubAssembler* assembler) const {
-  compiler::Node* result = assembler->Allocate(
-      HeapNumber::kSize, compiler::CodeStubAssembler::kNone);
-  compiler::Node* map_offset =
-      assembler->IntPtrConstant(HeapObject::kMapOffset - kHeapObjectTag);
-  compiler::Node* map = assembler->IntPtrAdd(result, map_offset);
-  assembler->StoreNoWriteBarrier(
-      MachineRepresentation::kTagged, map,
-      assembler->HeapConstant(isolate()->factory()->heap_number_map()));
+  typedef compiler::Node Node;
+
+  Node* result = assembler->AllocateHeapNumber();
   assembler->Return(result);
 }
 
 void AllocateMutableHeapNumberStub::GenerateAssembly(
     compiler::CodeStubAssembler* assembler) const {
-  compiler::Node* result = assembler->Allocate(
-      HeapNumber::kSize, compiler::CodeStubAssembler::kNone);
-  compiler::Node* map_offset =
-      assembler->IntPtrConstant(HeapObject::kMapOffset - kHeapObjectTag);
-  compiler::Node* map = assembler->IntPtrAdd(result, map_offset);
-  assembler->StoreNoWriteBarrier(
-      MachineRepresentation::kTagged, map,
+  typedef compiler::Node Node;
+
+  Node* result = assembler->Allocate(HeapNumber::kSize);
+  assembler->StoreMapNoWriteBarrier(
+      result,
       assembler->HeapConstant(isolate()->factory()->mutable_heap_number_map()));
   assembler->Return(result);
 }
 
 #define SIMD128_GEN_ASM(TYPE, Type, type, lane_count, lane_type)            \
   void Allocate##Type##Stub::GenerateAssembly(                              \
       compiler::CodeStubAssembler* assembler) const {                       \
     compiler::Node* result = assembler->Allocate(                           \
         Simd128Value::kSize, compiler::CodeStubAssembler::kNone);           \
     compiler::Node* map_offset =                                            \
@@ skipping 362 matching lines @@
       }
     }
   }
 
   assembler->Bind(&do_fadd);
   {
     Node* lhs_value = var_fadd_lhs.value();
     Node* rhs_value = var_fadd_rhs.value();
     Node* value = assembler->Float64Add(lhs_value, rhs_value);
     // TODO(bmeurer): Introduce a ChangeFloat64ToTagged.
-    Node* result = assembler->Allocate(HeapNumber::kSize,
-                                       compiler::CodeStubAssembler::kNone);
-    assembler->StoreMapNoWriteBarrier(result,
-                                      assembler->HeapNumberMapConstant());
-    assembler->StoreHeapNumberValue(result, value);
+    Node* result = assembler->AllocateHeapNumberWithValue(value);
     assembler->Return(result);
   }
 }
 
 void SubtractStub::GenerateAssembly(
     compiler::CodeStubAssembler* assembler) const {
   typedef compiler::CodeStubAssembler::Label Label;
   typedef compiler::Node Node;
   typedef compiler::CodeStubAssembler::Variable Variable;
 
@@ skipping 148 matching lines @@
       }
     }
   }
 
   assembler->Bind(&do_fsub);
   {
     Node* lhs_value = var_fsub_lhs.value();
     Node* rhs_value = var_fsub_rhs.value();
     Node* value = assembler->Float64Sub(lhs_value, rhs_value);
     // TODO(bmeurer): Introduce a ChangeFloat64ToTagged.
-    Node* result = assembler->Allocate(HeapNumber::kSize,
-                                       compiler::CodeStubAssembler::kNone);
-    assembler->StoreMapNoWriteBarrier(result,
-                                      assembler->HeapNumberMapConstant());
-    assembler->StoreHeapNumberValue(result, value);
+    Node* result = assembler->AllocateHeapNumberWithValue(value);
     assembler->Return(result);
   }
 }
 
 namespace {
 
 enum RelationalComparisonMode {
   kLessThan,
   kLessThanOrEqual,
   kGreaterThan,
@@ skipping 2293 matching lines @@
   if (type->Is(Type::UntaggedPointer())) {
     return Representation::External();
   }
 
   DCHECK(!type->Is(Type::Untagged()));
   return Representation::Tagged();
 }
 
 }  // namespace internal
 }  // namespace v8