Gerrit: make git cl close working.

Gerrit: make git cl close working.

BUG=579160
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299465

[tandrii(chromium), 2016-03-24 10:29:23]

tandrii@chromium.org changed reviewers:
+ machenbach@chromium.org

[tandrii(chromium), 2016-03-24 10:29:24]

PTAL

[tandrii(chromium), 2016-03-24 10:29:27]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-24 10:29:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827523003/20001

[commit-bot: I haz the power, 2016-03-24 10:29:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 10:29:35]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-infra-committers".
Note that this has nothing to do with OWNERS files.

[tandrii(chromium), 2016-03-24 10:29:35]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2016-03-24 10:29:39]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-24 10:29:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827523003/20001

[commit-bot: I haz the power, 2016-03-24 10:32:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-24 10:32:10]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-03-24 12:38:26]

lgtm

https://codereview.chromium.org/1827523003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/1827523003/diff/20001/git_cl.py#newcode1598
git_cl.py:1598: gerrit_util.AbandonChange(self._GetGerritHost(),
self.GetIssue(), msg='')
I assume this has no test, otherwise I'd have expected to see some test
expectation changes, right?

[tandrii(chromium), 2016-03-24 12:41:32]

On 2016/03/24 12:38:26, Michael Achenbach wrote:
> lgtm
> 
> https://codereview.chromium.org/1827523003/diff/20001/git_cl.py
> File git_cl.py (right):
> 
> https://codereview.chromium.org/1827523003/diff/20001/git_cl.py#newcode1598
> git_cl.py:1598: gerrit_util.AbandonChange(self._GetGerritHost(),
> self.GetIssue(), msg='')
> I assume this has no test, otherwise I'd have expected to see some test
> expectation changes, right?

Yeah, rietveld version has none either. But once this lands, i'll have test as
well.

[tandrii(chromium), 2016-03-24 12:41:44]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-03-24 12:41:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1827523003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1827523003/20001

[commit-bot: I haz the power, 2016-03-24 12:44:26]

Description was changed from

==========
Gerrit: make git cl close working.

BUG=579160
==========

to

==========
Gerrit: make git cl close working.

BUG=579160

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299465
==========

[commit-bot: I haz the power, 2016-03-24 12:44:27]

Committed patchset #2 (id:20001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299465

[tandrii(chromium), 2016-03-24 17:32:19]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1829083002/ by tandrii@chromium.org.

The reason for reverting is: broke presubmit.