Gerrit: make git cl close working.

git_cl.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # Copyright (C) 2008 Evan Martin <martine@danga.com>
 
 """A git-command for integrating reviews on Rietveld and Gerrit."""
 
 from distutils.version import LooseVersion
@@ skipping 1577 matching lines @@
   def FetchDescription(self):
     data = gerrit_util.GetChangeDetail(self._GetGerritHost(), self.GetIssue(),
                                        ['COMMIT_FOOTERS', 'CURRENT_REVISION'])
     return data['revisions'][data['current_revision']]['commit_with_footers']
 
   def UpdateDescriptionRemote(self, description):
     # TODO(tandrii)
     raise NotImplementedError()
 
   def CloseIssue(self):
-    # TODO(tandrii)
-    raise NotImplementedError()
+    gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')

[Michael Achenbach, 2016/03/24 12:38:26]

I assume this has no test, otherwise I'd have expected to see some test
expectation changes, right?

 
 
 class ChangeDescription(object):
   """Contains a parsed form of the change description."""
   R_LINE = r'^[ \t]*(TBR|R)[ \t]*=[ \t]*(.*?)[ \t]*$'
   BUG_LINE = r'^[ \t]*(BUG)[ \t]*=[ \t]*(.*?)[ \t]*$'
 
   def __init__(self, description):
     self._description_lines = (description or '').strip().splitlines()
 
@@ skipping 2659 matching lines @@
 if __name__ == '__main__':
   # These affect sys.stdout so do it outside of main() to simplify mocks in
   # unit testing.
   fix_encoding.fix_encoding()
   colorama.init()
   try:
     sys.exit(main(sys.argv[1:]))
   except KeyboardInterrupt:
     sys.stderr.write('interrupted\n')
     sys.exit(1)