git_cl.py - Issue 1827523003: Gerrit: make git cl close working.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: git_cl.py

Issue 1827523003: Gerrit: make git cl close working. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@G101

Patch Set: a Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: git_cl.py

diff --git a/git_cl.py b/git_cl.py

index 98a2f01b44485b746fb82c3ad290d5f379e3eab7..aab9d80781889dc8de87c3f82a245da80c70077b 100755

--- a/git_cl.py

+++ b/git_cl.py

@@ -1595,8 +1595,7 @@ class _GerritChangelistImpl(_ChangelistCodereviewBase):

raise NotImplementedError()

def CloseIssue(self):

- # TODO(tandrii)

- raise NotImplementedError()

+ gerrit_util.AbandonChange(self._GetGerritHost(), self.GetIssue(), msg='')

Michael Achenbach 2016/03/24 12:38:26 I assume this has no test, otherwise I'd have expe

class ChangeDescription(object):

« no previous file with comments | « no previous file | no next file » | no next file with comments »