Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1827323003: [Telemetry] Clear tracing state before browser start (Closed)

Created:
4 years, 9 months ago by Zhen Wang
Modified:
4 years, 8 months ago
Reviewers:
nednguyen
CC:
catapult-reviews_chromium.org
Base URL:
git@github.com:catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Clear tracing state before browser start For TimelineBasedMeasurement benchmarks, tracing has already started before starting browser. For PageTest benchmarks, tracing has not yet started before starting browser. We need to make sure no tracing state is left before starting the browser for PageTest benchmarks. BUG=chromium:596464 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bc0655db4a8ec68d1b180907e235eeaf17dbb33a

Patch Set 1 #

Patch Set 2 : fix test #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -0 lines) Patch
M telemetry/telemetry/core/tracing_controller.py View 1 chunk +4 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py View 1 chunk +9 lines, -0 lines 0 comments Download
M telemetry/telemetry/internal/platform/tracing_controller_backend.py View 1 chunk +3 lines, -0 lines 0 comments Download
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +7 lines, -0 lines 1 comment Download
M telemetry/telemetry/testing/fakes/__init__.py View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Zhen Wang
ptal
4 years, 9 months ago (2016-03-25 15:04:47 UTC) #4
nednguyen
lgtm
4 years, 9 months ago (2016-03-25 15:19:31 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827323003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827323003/20001
4 years, 9 months ago (2016-03-25 15:19:42 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/bc0655db4a8ec68d1b180907e235eeaf17dbb33a
4 years, 9 months ago (2016-03-25 15:32:34 UTC) #9
nednguyen
4 years, 8 months ago (2016-04-11 18:12:29 UTC) #10
Message was sent while issue was closed.
https://codereview.chromium.org/1827323003/diff/20001/telemetry/telemetry/pag...
File telemetry/telemetry/page/shared_page_state.py (right):

https://codereview.chromium.org/1827323003/diff/20001/telemetry/telemetry/pag...
telemetry/telemetry/page/shared_page_state.py:224: if not
self.platform.tracing_controller.is_tracing_running:
Actually, I think we should move this to browser.Start() method.

Powered by Google App Engine
This is Rietveld 408576698