Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: telemetry/telemetry/page/shared_page_state.py

Issue 1827323003: [Telemetry] Clear tracing state before browser start (Closed) Base URL: git@github.com:catapult-project/catapult@master
Patch Set: fix test Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/page/shared_page_state.py
diff --git a/telemetry/telemetry/page/shared_page_state.py b/telemetry/telemetry/page/shared_page_state.py
index d9ea430a2cfe914230057ea1840e7ddd8ccf5e33..454a08794304a9a2e2eb19fc0588dc1acc00940a 100644
--- a/telemetry/telemetry/page/shared_page_state.py
+++ b/telemetry/telemetry/page/shared_page_state.py
@@ -221,6 +221,13 @@ class SharedPageState(story.SharedState):
logging.warning('System info not supported')
def WillRunStory(self, page):
+ if not self.platform.tracing_controller.is_tracing_running:
nednguyen 2016/04/11 18:12:29 Actually, I think we should move this to browser.S
+ # For TimelineBasedMeasurement benchmarks, tracing has already started.
+ # For PageTest benchmarks, tracing has not yet started. We need to make
+ # sure no tracing state is left before starting the browser for PageTest
+ # benchmarks.
+ self.platform.tracing_controller.ClearStateIfNeeded()
+
if self._ShouldDownloadPregeneratedProfileArchive():
self._DownloadPregeneratedProfileArchive()
« no previous file with comments | « telemetry/telemetry/internal/platform/tracing_controller_backend.py ('k') | telemetry/telemetry/testing/fakes/__init__.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698