telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py - Issue 1827323003: [Telemetry] Clear tracing state before browser start

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py

Issue 1827323003: [Telemetry] Clear tracing state before browser start (Closed) Base URL: git@github.com:catapult-project/catapult@master

Patch Set: fix test Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « telemetry/telemetry/core/tracing_controller.py ('k') | telemetry/telemetry/internal/platform/tracing_controller_backend.py » ('j') | telemetry/telemetry/page/shared_page_state.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py

diff --git a/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py b/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py

index d6485212e31c5c872c96612047e94111e007a667..e05ff2ae599ad349534822a35159420377addd45 100644

--- a/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py

+++ b/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py

@@ -24,6 +24,15 @@ _CHROME_TRACE_CONFIG_DIR_ANDROID = '/data/local/'

_CHROME_TRACE_CONFIG_FILE_NAME = 'chrome-trace-config.json'

+def ClearStarupTracingStateIfNeeded(platform_backend):

+ # Trace config file has fixed path on Android and temporary path on desktop.

+ if platform_backend.GetOSName() == 'android':

+ trace_config_file = os.path.join(_CHROME_TRACE_CONFIG_DIR_ANDROID,

+ _CHROME_TRACE_CONFIG_FILE_NAME)

+ platform_backend.device.RunShellCommand(

+ ['rm', '-f', trace_config_file], check_return=True, as_root=True)

class ChromeTracingStartedError(Exception):

pass