Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Issue 1827123002: Move content/common/gpu/client to gpu/ipc/client (Closed)

Created:
4 years, 9 months ago by Peng
Modified:
4 years, 8 months ago
Reviewers:
jam, piman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, posciak+watch_chromium.org, avayvod+watch_chromium.org, nasko+codewatch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, mkwst+moarreviews-renderer_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org, mlamouri+watch-media_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move content/common/gpu/client to gpu/ipc/client BUG=586380 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/346a46f9cc4151e989b961d2d0429d16aeb49c14 Cr-Commit-Position: refs/heads/master@{#384397}

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Rebase #

Patch Set 4 : Update #

Patch Set 5 : y #

Patch Set 6 : . #

Patch Set 7 : Update #

Patch Set 8 : Update #

Patch Set 9 : Update #

Patch Set 10 : update #

Patch Set 11 : update #

Patch Set 12 : Update #

Patch Set 13 : Update #

Patch Set 14 : Update #

Patch Set 15 : update #

Patch Set 16 : Rebase #

Patch Set 17 : cl format #

Patch Set 18 : Update #

Total comments: 2

Patch Set 19 : Update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+525 lines, -3503 lines) Patch
M base/threading/thread_restrictions.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 3 chunks +4 lines, -2 lines 0 comments Download
M content/browser/android/in_process/synchronous_compositor_factory_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +1 line, -1 line 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_browser_compositor_output_surface.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/compositor/gpu_process_transport_factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +4 lines, -4 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.h View 1 2 chunks +7 lines, -6 lines 0 comments Download
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/gpu/browser_gpu_memory_buffer_manager.cc View 1 9 chunks +15 lines, -14 lines 0 comments Download
M content/browser/gpu/gpu_ipc_browsertests.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 5 chunks +6 lines, -8 lines 0 comments Download
M content/browser/renderer_host/compositor_impl_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.h View 1 3 chunks +7 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/video_capture_gpu_jpeg_decoder.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -1 line 0 comments Download
M content/child/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M content/child/child_gpu_memory_buffer_manager.cc View 1 3 chunks +9 lines, -8 lines 0 comments Download
M content/child/child_thread_impl_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/BUILD.gn View 1 2 4 chunks +1 line, -6 lines 0 comments Download
M content/common/child_process_host_impl.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
D content/common/gpu/client/command_buffer_proxy_impl.h View 1 chunk +0 lines, -254 lines 0 comments Download
D content/common/gpu/client/command_buffer_proxy_impl.cc View 1 chunk +0 lines, -747 lines 0 comments Download
D content/common/gpu/client/context_provider_command_buffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
D content/common/gpu/client/context_provider_command_buffer.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D content/common/gpu/client/gpu_channel_host.h View 1 chunk +0 lines, -299 lines 0 comments Download
D content/common/gpu/client/gpu_channel_host.cc View 1 chunk +0 lines, -481 lines 0 comments Download
D content/common/gpu/client/gpu_context_tests.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -4 lines 0 comments Download
M content/common/gpu/client/gpu_jpeg_decode_accelerator_host.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M content/common/gpu/client/gpu_jpeg_decode_accelerator_host.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl.h View 1 chunk +0 lines, -68 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl.cc View 1 chunk +0 lines, -94 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_io_surface.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_io_surface.cc View 1 chunk +0 lines, -124 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_io_surface_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 chunk +0 lines, -63 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 1 chunk +0 lines, -111 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_ozone_native_pixmap_unittest.cc View 1 chunk +0 lines, -16 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.h View 1 chunk +0 lines, -77 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_shared_memory.cc View 1 chunk +0 lines, -224 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_shared_memory_unittest.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.h View 1 chunk +0 lines, -60 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_surface_texture.cc View 1 chunk +0 lines, -150 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_surface_texture_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 2 chunks +4 lines, -4 lines 0 comments Download
D content/common/gpu/client/gpu_memory_buffer_impl_test_template.h View 1 chunk +0 lines, -207 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.h View 1 4 chunks +14 lines, -11 lines 0 comments Download
M content/common/gpu/client/gpu_video_decode_accelerator_host.cc View 1 3 chunks +5 lines, -5 lines 0 comments Download
M content/common/gpu/client/gpu_video_encode_accelerator_host.h View 1 6 chunks +14 lines, -11 lines 0 comments Download
M content/common/gpu/client/gpu_video_encode_accelerator_host.cc View 1 3 chunks +4 lines, -4 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +7 lines, -7 lines 0 comments Download
M content/common/gpu/client/webgraphicscontext3d_command_buffer_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 7 chunks +11 lines, -9 lines 0 comments Download
M content/common/gpu/media/gpu_video_encode_accelerator.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 4 chunks +0 lines, -18 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +1 line, -4 lines 0 comments Download
M content/renderer/gpu/compositor_output_surface.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/gpu/stream_texture_host_android.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +6 lines, -3 lines 0 comments Download
M content/renderer/gpu/stream_texture_host_android.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +2 lines, -2 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.h View 1 2 3 4 5 6 7 8 9 2 chunks +5 lines, -5 lines 0 comments Download
M content/renderer/media/android/stream_texture_factory_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.h View 1 4 chunks +4 lines, -4 lines 0 comments Download
M content/renderer/media/renderer_gpu_video_accelerator_factories.cc View 1 7 chunks +7 lines, -7 lines 0 comments Download
M content/renderer/media/video_capture_impl.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_video_decoder_host.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/pepper_video_encoder_host.h View 1 2 chunks +7 lines, -4 lines 0 comments Download
M content/renderer/pepper/pepper_video_encoder_host.cc View 1 3 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.h View 1 2 3 4 5 6 7 3 chunks +6 lines, -6 lines 0 comments Download
M content/renderer/pepper/ppb_graphics_3d_impl.cc View 1 2 3 4 5 6 7 5 chunks +7 lines, -6 lines 0 comments Download
M content/renderer/pepper/ppb_video_decoder_impl.cc View 1 2 4 chunks +4 lines, -3 lines 0 comments Download
M content/renderer/render_thread_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 7 chunks +9 lines, -7 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 8 chunks +9 lines, -13 lines 0 comments Download
M content/renderer/render_widget.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 5 chunks +5 lines, -5 lines 0 comments Download
M content/test/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 1 chunk +1 line, -0 lines 0 comments Download
M gpu/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 3 chunks +11 lines, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 10 chunks +36 lines, -2 lines 0 comments Download
A + gpu/gpu_ipc_client.gypi View 1 2 3 4 5 6 7 8 9 10 2 chunks +27 lines, -13 lines 0 comments Download
A gpu/ipc/client/BUILD.gn View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +70 lines, -0 lines 0 comments Download
A + gpu/ipc/client/DEPS View 1 2 3 0 chunks +-1 lines, --1 lines 0 comments Download
A + gpu/ipc/client/command_buffer_proxy_impl.h View 1 6 chunks +10 lines, -10 lines 0 comments Download
A + gpu/ipc/client/command_buffer_proxy_impl.cc View 1 12 chunks +22 lines, -34 lines 0 comments Download
A + gpu/ipc/client/gpu_channel_host.h View 1 5 chunks +10 lines, -9 lines 0 comments Download
A + gpu/ipc/client/gpu_channel_host.cc View 1 7 chunks +9 lines, -12 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl.h View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl.cc View 1 2 chunks +7 lines, -7 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_io_surface.h View 1 3 chunks +8 lines, -8 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_io_surface.cc View 1 4 chunks +5 lines, -7 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_io_surface_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_ozone_native_pixmap_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.h View 1 2 chunks +8 lines, -9 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_shared_memory.cc View 1 7 8 9 10 4 chunks +4 lines, -5 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_shared_memory_unittest.cc View 1 2 chunks +4 lines, -4 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_surface_texture.h View 1 2 chunks +8 lines, -8 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_surface_texture.cc View 1 4 chunks +7 lines, -7 lines 0 comments Download
A + gpu/ipc/client/gpu_memory_buffer_impl_test_template.h View 1 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
Peng
Hi piman, PTAL. Thanks.
4 years, 8 months ago (2016-03-31 17:51:24 UTC) #7
piman
LGTM, awesome.
4 years, 8 months ago (2016-03-31 19:17:19 UTC) #8
Peng
+jam for base/threading/thread_restrictions.h Hi jam, PTAL. Thanks.
4 years, 8 months ago (2016-03-31 19:25:57 UTC) #10
jam
On 2016/03/31 19:25:57, Peng wrote: > +jam for base/threading/thread_restrictions.h > > Hi jam, PTAL. Thanks. ...
4 years, 8 months ago (2016-03-31 19:49:44 UTC) #11
Peng
https://codereview.chromium.org/1827123002/diff/390001/base/threading/thread_restrictions.h File base/threading/thread_restrictions.h (right): https://codereview.chromium.org/1827123002/diff/390001/base/threading/thread_restrictions.h#newcode226 base/threading/thread_restrictions.h:226: friend class gpu::GpuChannelHost; // http://crbug.com/125264 On 2016/03/31 19:49:44, jam ...
4 years, 8 months ago (2016-03-31 19:53:22 UTC) #12
Peng
4 years, 8 months ago (2016-03-31 19:53:24 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827123002/410001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827123002/410001
4 years, 8 months ago (2016-03-31 19:54:34 UTC) #16
commit-bot: I haz the power
Committed patchset #19 (id:410001)
4 years, 8 months ago (2016-03-31 21:38:02 UTC) #17
commit-bot: I haz the power
4 years, 8 months ago (2016-03-31 21:39:20 UTC) #19
Message was sent while issue was closed.
Patchset 19 (id:??) landed as
https://crrev.com/346a46f9cc4151e989b961d2d0429d16aeb49c14
Cr-Commit-Position: refs/heads/master@{#384397}

Powered by Google App Engine
This is Rietveld 408576698