Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1827083004: UI: Rename MediaState to AlertState (Closed)

Created:
4 years, 9 months ago by ortuno
Modified:
4 years, 8 months ago
Reviewers:
felt, Ilya Sherman, miu, sky
CC:
asvitkine+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, Jeffrey Yasskin, miu+watch_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-tab-indicator
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

UI: Rename MediaState to AlertState With the inclusion of Bluetooth to the Media State Indicator, the name "Media State Indicator" becomes a misnomer. This patch makes the enum "TabMediaState" into an "enum class" named "TabAlertState" and renames the class "MediaIndicatorButton" to "AlertIndicatorButton". Since we were there already, this patch also converts the "TabMutedReason" and "TabMutedResult" into enum classes. See issue for a summary of the new names. BUG=598086 Committed: https://crrev.com/71c3f14505c8c25dad48ab124da342f579a315fb Cr-Commit-Position: refs/heads/master@{#384028}

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Patch Set 3 : Change cocoa #

Patch Set 4 : Rename to alert state #

Total comments: 2

Patch Set 5 : Sett -> See #

Total comments: 4

Patch Set 6 : Keep gypi ordered #

Unified diffs Side-by-side diffs Delta from patch set Stats (+687 lines, -1546 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc View 1 2 3 3 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_api.cc View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/extension_tab_util.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.h View 1 2 3 2 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa.mm View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.h View 1 2 3 4 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/cocoa/browser_window_controller.mm View 1 2 3 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.h View 1 2 3 5 chunks +14 lines, -14 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm View 1 2 3 8 chunks +33 lines, -33 lines 0 comments Download
A + chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa_unittest.mm View 1 2 3 6 chunks +18 lines, -18 lines 0 comments Download
D chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.h View 1 2 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.mm View 1 2 1 chunk +0 lines, -240 lines 0 comments Download
D chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa_unittest.mm View 1 2 1 chunk +0 lines, -90 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.h View 1 2 3 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller.mm View 1 2 3 7 chunks +35 lines, -35 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm View 1 2 3 8 chunks +50 lines, -49 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.h View 1 2 3 1 chunk +10 lines, -10 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm View 1 2 3 6 chunks +31 lines, -31 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm View 1 2 3 8 chunks +61 lines, -61 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/tabs/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_strip_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/tabs/tab_utils.h View 1 2 3 1 chunk +40 lines, -40 lines 0 comments Download
M chrome/browser/ui/tabs/tab_utils.cc View 1 2 3 10 chunks +80 lines, -80 lines 0 comments Download
M chrome/browser/ui/views/tabs/OWNERS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/views/tabs/alert_indicator_button.h View 1 2 3 4 chunks +22 lines, -24 lines 0 comments Download
A + chrome/browser/ui/views/tabs/alert_indicator_button.cc View 1 2 3 10 chunks +61 lines, -61 lines 0 comments Download
A + chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc View 1 2 3 5 chunks +17 lines, -20 lines 0 comments Download
M chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/ui/views/tabs/media_indicator_button.h View 1 chunk +0 lines, -103 lines 0 comments Download
D chrome/browser/ui/views/tabs/media_indicator_button.cc View 1 chunk +0 lines, -269 lines 0 comments Download
D chrome/browser/ui/views/tabs/media_indicator_button_unittest.cc View 1 chunk +0 lines, -113 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 2 3 8 chunks +13 lines, -13 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 1 2 3 15 chunks +36 lines, -36 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_renderer_data.cc View 1 2 3 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_unittest.cc View 1 2 3 10 chunks +47 lines, -46 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 4 5 2 chunks +2 lines, -2 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 2 3 7 chunks +40 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 29 (13 generated)
miu
Hmm...The word "permission" is also a misnomer here. ;-) For some of these, there is ...
4 years, 9 months ago (2016-03-25 23:35:22 UTC) #4
ortuno
On 2016/03/25 at 23:35:22, miu wrote: > Hmm...The word "permission" is also a misnomer here. ...
4 years, 8 months ago (2016-03-28 20:59:31 UTC) #7
ortuno
@felt: miu suggested TabAlert state. Is that OK?
4 years, 8 months ago (2016-03-28 21:00:26 UTC) #9
felt
On 2016/03/28 21:00:26, ortuno wrote: > @felt: miu suggested TabAlert state. Is that OK? sure, ...
4 years, 8 months ago (2016-03-28 21:02:14 UTC) #10
miu
On 2016/03/28 20:59:31, ortuno wrote: > On 2016/03/25 at 23:35:22, miu wrote: > > Also, ...
4 years, 8 months ago (2016-03-28 22:19:39 UTC) #11
ortuno
@miu: PTAL
4 years, 8 months ago (2016-03-29 00:53:16 UTC) #13
miu
lgtm! Thanks for doing this follow-up change, and kudos for the extra tab mute enum ...
4 years, 8 months ago (2016-03-29 02:22:53 UTC) #14
ortuno
Thanks! https://codereview.chromium.org/1827083004/diff/60001/chrome/browser/ui/cocoa/browser_window_controller.h File chrome/browser/ui/cocoa/browser_window_controller.h (right): https://codereview.chromium.org/1827083004/diff/60001/chrome/browser/ui/cocoa/browser_window_controller.h#newcode384 chrome/browser/ui/cocoa/browser_window_controller.h:384: // Sett TabUtils::TabAlertState for a list of all ...
4 years, 8 months ago (2016-03-29 15:14:54 UTC) #15
ortuno
felt: PTAL sky: PTAL at chrome/browser/ui/ isherman: PTAL at tools/metrics/actions
4 years, 8 months ago (2016-03-29 15:20:36 UTC) #17
felt
lgtm, nice change; you also might want to mention the new enum in the description
4 years, 8 months ago (2016-03-29 16:51:28 UTC) #18
Ilya Sherman
actions.xml lgtm
4 years, 8 months ago (2016-03-30 01:18:59 UTC) #21
sky
LGTM https://codereview.chromium.org/1827083004/diff/80001/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/1827083004/diff/80001/chrome/chrome_browser_ui.gypi#newcode2463 chrome/chrome_browser_ui.gypi:2463: 'browser/ui/views/tabs/alert_indicator_button.cc', nit: keep sorted. https://codereview.chromium.org/1827083004/diff/80001/chrome/chrome_tests_unit.gypi File chrome/chrome_tests_unit.gypi (right): ...
4 years, 8 months ago (2016-03-30 15:48:21 UTC) #22
ortuno
Thanks! https://codereview.chromium.org/1827083004/diff/80001/chrome/chrome_browser_ui.gypi File chrome/chrome_browser_ui.gypi (right): https://codereview.chromium.org/1827083004/diff/80001/chrome/chrome_browser_ui.gypi#newcode2463 chrome/chrome_browser_ui.gypi:2463: 'browser/ui/views/tabs/alert_indicator_button.cc', On 2016/03/30 at 15:48:21, sky wrote: > ...
4 years, 8 months ago (2016-03-30 17:01:07 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1827083004/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1827083004/100001
4 years, 8 months ago (2016-03-30 17:01:39 UTC) #26
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 8 months ago (2016-03-30 18:27:08 UTC) #27
commit-bot: I haz the power
4 years, 8 months ago (2016-03-30 18:28:40 UTC) #29
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/71c3f14505c8c25dad48ab124da342f579a315fb
Cr-Commit-Position: refs/heads/master@{#384028}

Powered by Google App Engine
This is Rietveld 408576698