|
UI: Rename MediaState to AlertState
With the inclusion of Bluetooth to the Media State Indicator, the name
"Media State Indicator" becomes a misnomer. This patch makes the enum
"TabMediaState" into an "enum class" named "TabAlertState" and renames the class
"MediaIndicatorButton" to "AlertIndicatorButton".
Since we were there already, this patch also converts the "TabMutedReason" and
"TabMutedResult" into enum classes.
See issue for a summary of the new names.
BUG= 598086
Committed: https://crrev.com/71c3f14505c8c25dad48ab124da342f579a315fb
Cr-Commit-Position: refs/heads/master@{#384028}
Total comments: 2
Total comments: 4
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+687 lines, -1546 lines) |
Patch |
 |
M |
chrome/app/generated_resources.grd
|
View
|
1
2
3
|
1 chunk |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/tab_capture/tab_capture_apitest.cc
|
View
|
1
2
3
|
3 chunks |
+11 lines, -11 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/api/tabs/tabs_api.cc
|
View
|
1
2
3
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/extensions/extension_tab_util.cc
|
View
|
|
1 chunk |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser_window_cocoa.h
|
View
|
1
2
3
|
2 chunks |
+12 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser_window_cocoa.mm
|
View
|
1
2
3
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm
|
View
|
1
2
3
|
1 chunk |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser_window_controller.h
|
View
|
1
2
3
4
|
1 chunk |
+6 lines, -5 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/browser_window_controller.mm
|
View
|
1
2
3
|
1 chunk |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/OWNERS
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.h
|
View
|
1
2
3
|
5 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa.mm
|
View
|
1
2
3
|
8 chunks |
+33 lines, -33 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/cocoa/tabs/alert_indicator_button_cocoa_unittest.mm
|
View
|
1
2
3
|
6 chunks |
+18 lines, -18 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.h
|
View
|
1
2
|
1 chunk |
+0 lines, -83 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa.mm
|
View
|
1
2
|
1 chunk |
+0 lines, -240 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/cocoa/tabs/media_indicator_button_cocoa_unittest.mm
|
View
|
1
2
|
1 chunk |
+0 lines, -90 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_controller.h
|
View
|
1
2
3
|
5 chunks |
+6 lines, -6 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_controller.mm
|
View
|
1
2
3
|
7 chunks |
+35 lines, -35 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_controller_unittest.mm
|
View
|
1
2
3
|
8 chunks |
+50 lines, -49 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_strip_controller.h
|
View
|
1
2
3
|
1 chunk |
+10 lines, -10 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_strip_controller.mm
|
View
|
1
2
3
|
6 chunks |
+31 lines, -31 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_strip_controller_unittest.mm
|
View
|
1
2
3
|
8 chunks |
+61 lines, -61 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/cocoa/tabs/tab_view.mm
|
View
|
1
2
3
|
2 chunks |
+3 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/tabs/OWNERS
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/tabs/tab_strip_model.cc
|
View
|
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/tabs/tab_utils.h
|
View
|
1
2
3
|
1 chunk |
+40 lines, -40 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/tabs/tab_utils.cc
|
View
|
1
2
3
|
10 chunks |
+80 lines, -80 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/OWNERS
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/views/tabs/alert_indicator_button.h
|
View
|
1
2
3
|
4 chunks |
+22 lines, -24 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/views/tabs/alert_indicator_button.cc
|
View
|
1
2
3
|
10 chunks |
+61 lines, -61 lines |
0 comments
|
Download
|
 |
A + |
chrome/browser/ui/views/tabs/alert_indicator_button_unittest.cc
|
View
|
1
2
3
|
5 chunks |
+17 lines, -20 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/tabs/media_indicator_button.h
|
View
|
|
1 chunk |
+0 lines, -103 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/tabs/media_indicator_button.cc
|
View
|
|
1 chunk |
+0 lines, -269 lines |
0 comments
|
Download
|
 |
D |
chrome/browser/ui/views/tabs/media_indicator_button_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -113 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab.h
|
View
|
1
2
3
|
8 chunks |
+13 lines, -13 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab.cc
|
View
|
1
2
3
|
15 chunks |
+36 lines, -36 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab_renderer_data.h
|
View
|
1
2
3
|
1 chunk |
+1 line, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab_renderer_data.cc
|
View
|
1
2
3
|
2 chunks |
+2 lines, -3 lines |
0 comments
|
Download
|
 |
M |
chrome/browser/ui/views/tabs/tab_unittest.cc
|
View
|
1
2
3
|
10 chunks |
+47 lines, -46 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_browser_ui.gypi
|
View
|
1
2
3
4
5
|
2 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
chrome/chrome_tests_unit.gypi
|
View
|
1
2
3
4
5
|
2 chunks |
+2 lines, -2 lines |
0 comments
|
Download
|
 |
M |
tools/metrics/actions/actions.xml
|
View
|
1
2
3
|
7 chunks |
+40 lines, -0 lines |
0 comments
|
Download
|
Depends on Patchset:
Total messages: 29 (13 generated)
|