chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm - Issue 1827083004: UI: Rename MediaState to AlertState

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

Issue 1827083004: UI: Rename MediaState to AlertState (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-tab-indicator

Patch Set: Keep gypi ordered Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm b/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

index a55de3d3f7051ab0780d9a2f54841909e75dd5ca..4f332a79ff888e05f06e240364d0b0931cfccb3a 100644

--- a/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/browser_window_cocoa_unittest.mm

@@ -59,13 +59,13 @@ TEST_F(BrowserWindowCocoaTest, TestWindowTitle) {

[bwc->WindowTitle() rangeOfString:playing_emoji].location);

EXPECT_EQ(static_cast<NSUInteger>(NSNotFound),

[bwc->WindowTitle() rangeOfString:muting_emoji].location);

- bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_PLAYING);

+ bwc->UpdateAlertState(TabAlertState::AUDIO_PLAYING);

EXPECT_NE(static_cast<NSUInteger>(NSNotFound),

[bwc->WindowTitle() rangeOfString:playing_emoji].location);

- bwc->UpdateMediaState(TAB_MEDIA_STATE_AUDIO_MUTING);

+ bwc->UpdateAlertState(TabAlertState::AUDIO_MUTING);

EXPECT_NE(static_cast<NSUInteger>(NSNotFound),

[bwc->WindowTitle() rangeOfString:muting_emoji].location);

- bwc->UpdateMediaState(TAB_MEDIA_STATE_NONE);

+ bwc->UpdateAlertState(TabAlertState::NONE);

EXPECT_EQ(static_cast<NSUInteger>(NSNotFound),

[bwc->WindowTitle() rangeOfString:playing_emoji].location);

EXPECT_EQ(static_cast<NSUInteger>(NSNotFound),

« no previous file with comments | « chrome/browser/ui/cocoa/browser_window_cocoa.mm ('k') | chrome/browser/ui/cocoa/browser_window_controller.h » ('j') | no next file with comments »